Closed Bug 1120262 Opened 5 years ago Closed 5 years ago

Replace PL_DHashTableOperate with PL_DHashTable{Add,Remove} in RDF

Categories

(Core Graveyard :: RDF, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla38

People

(Reporter: michael, Assigned: michael)

References

Details

Attachments

(1 file)

With bug 1118024, most calls to PL_DHashTableOperate() were replaced with calls to PL_DHashTableAdd() or PL_DHashTableRemove(). Two calls to PL_DHashTableOperate() remain in InMemoryDataSource's SetForwardArcs() and SetReverseArcs() methods.
Attached patch PatchSplinter Review
This patch replaces calls to PL_DHashTableOperate() with calls to PL_DHashTableAdd() and PL_DHashTableRemove().

Here are the results of the try server:

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ededfa1dd64f
Assignee: nobody → michael
Attachment #8547277 - Flags: feedback?(nfroyd)
Comment on attachment 8547277 [details] [diff] [review]
Patch

Review of attachment 8547277 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  I don't think there's much value in having somebody else look at the patch, so I'm going to mark this with r+, too.
Attachment #8547277 - Flags: review+
Attachment #8547277 - Flags: feedback?(nfroyd)
Attachment #8547277 - Flags: feedback+
https://hg.mozilla.org/mozilla-central/rev/4b1a5da9b12f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Is there a bug open for removing PL_DHashTableOperate() and its associated machinery (e.g. PL_DHASH_ADD)?
(In reply to Nicholas Nethercote [:njn] from comment #5)
> Is there a bug open for removing PL_DHashTableOperate() and its associated
> machinery (e.g. PL_DHASH_ADD)?

I'll file one.
Blocks: 1121202
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.