1120262 - Replace PL_DHashTableOperate with PL_DHashTable{Add,Remove} in RDF

Status: RESOLVED FIXED

(Core Graveyard :: RDF, defect)

Description

[Michael Pruett]

With bug 1118024, most calls to PL_DHashTableOperate() were replaced with calls to PL_DHashTableAdd() or PL_DHashTableRemove(). Two calls to PL_DHashTableOperate() remain in InMemoryDataSource's SetForwardArcs() and SetReverseArcs() methods.

Comment 1

[Michael Pruett]

Attachment: Patch

This patch replaces calls to PL_DHashTableOperate() with calls to PL_DHashTableAdd() and PL_DHashTableRemove().

Here are the results of the try server:

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=ededfa1dd64f

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8547277 [details] [diff] [review]
Patch

Review of attachment 8547277 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  I don't think there's much value in having somebody else look at the patch, so I'm going to mark this with r+, too.

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4b1a5da9b12f

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4b1a5da9b12f

Comment 5

[Nicholas Nethercote [inactive]]

Is there a bug open for removing PL_DHashTableOperate() and its associated machinery (e.g. PL_DHASH_ADD)?

Comment 6

[Nathan Froyd [:froydnj]]

(In reply to Nicholas Nethercote [:njn] from comment #5)
> Is there a bug open for removing PL_DHashTableOperate() and its associated
> machinery (e.g. PL_DHASH_ADD)?

I'll file one.