Closed Bug 1120266 Opened 6 years ago Closed 6 years ago

Add Fragmented MP4 samples

Categories

(Core :: Audio/Video, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox36 --- fixed
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files, 2 obsolete files)

We don't currently have properly fragmented mp4 video samples for use with mse tests.
I currently have these in my tests for bug 1120030. We should probably just check those partly in, and comment out the tests that aren't passing.
Depends on: 1120030
Attached patch Add fragmented mp4 sample videos (obsolete) — Splinter Review
some samples.
bipbop.mp4 non-fragmented mp4 sample (audio/video combined: mp4a.40.2, avc1.4d4015)
bipbopinit.mp4, bipbop[0-13].m4s: fragmented mp4 (audio/video combined: mp4a.40.2, avc1.4d4015)
bipbop_videoinit.mp4, bipbop_video[0-13].m4s: fragmented mp4 (video only: avc1.4d4015)
bipbop_audioinit.mp4, bipbop_audio[0-13].m4s: fragmented mp4 (audio only: mp4a.40.2)
Attachment #8547262 - Flags: review?(ajones)
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
(In reply to Bobby Holley (Busy with media, don't ask for DOM/JS/XPConnect things) from comment #1)
> I currently have these in my tests for bug 1120030. We should probably just
> check those partly in, and comment out the tests that aren't passing.

as you said, the gizmo are really crappy to test anything. You can't even tell for sure if the video has finished playing or played all its frames...
At least here you have a frame count showing, and an obvious way to tell A/V sync
k17e: bholley placed his samples in test/mediasource/fgizmo 

let me know if you want to follow a similar path structure, than the media/test ones.
Comment on attachment 8547262 [details] [diff] [review]
Add fragmented mp4 sample videos

I'll get cpearce to make the call on this patch.
Attachment #8547262 - Flags: review?(ajones) → review?(cpearce)
Comment on attachment 8547262 [details] [diff] [review]
Add fragmented mp4 sample videos

Review of attachment 8547262 [details] [diff] [review]:
-----------------------------------------------------------------

I'm fine with these being in dom/media/test, but I wonder if it's more appropriate for them to be in dom/media/mediasource/test?

I'll punt this to cajbir, he's got a better idea how testing MSE should be done.
Attachment #8547262 - Flags: review?(cpearce) → review?(cajbir.bugzilla)
I think they should be in mediasource/test
i put them in media/test because the EME mse files are there (gizmo-frag-*.mp4 etc)
Sure, the EME test files are in media/test because that's where all the EME mochitest HTML files are. If the EME mochitest files were in dom/media/eme/tests, would you put the MSE files in there? ;)
Attached patch Add fragmented mp4 sample videos (obsolete) — Splinter Review
Put bipbop.mp4 in media/test and all fragmented files in media/mediasource/test
Attachment #8547455 - Flags: review?(cajbir.bugzilla)
Attachment #8547262 - Attachment is obsolete: true
Attachment #8547262 - Flags: review?(cajbir.bugzilla)
(In reply to Chris Pearce (:cpearce) from comment #9)
> Sure, the EME test files are in media/test because that's where all the EME
> mochitest HTML files are. If the EME mochitest files were in
> dom/media/eme/tests, would you put the MSE files in there? ;)

well, I would argue that eme tests should be withing mediasource test folder, as they are using mediasource.

You're one of us !
Attachment #8547455 - Flags: review?(cajbir.bugzilla) → review+
I'll take care of moving these into a subdirectory, adding them to mochitest.ini, and getting them checked in.
Blocks: 1122153
I'm going to take care of landing this bug, along with a patch that jya r+ed
in bug 1120030.
Attachment #8549977 - Flags: review+
Fixed up this patch a bit.
Attachment #8547455 - Attachment is obsolete: true
Attachment #8549978 - Flags: review+
Blocks: 1121692
https://hg.mozilla.org/mozilla-central/rev/4c33a6636cc4
https://hg.mozilla.org/mozilla-central/rev/a4f7c77bec12
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment on attachment 8549977 [details] [diff] [review]
Factor some machinery out of test_BufferingWait into mediasource.js and make it Promise-friendly. v1 r=jya

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing.
[Describe test coverage new/current, TreeHerder]: Landed on m-c.
[Risks and why]: Test-only.
[String/UUID change made/needed]: None.

Nominating both patches in this bug so we get similar test coverage on all branches.
Attachment #8549977 - Flags: approval-mozilla-beta?
Attachment #8549977 - Flags: approval-mozilla-aurora?
Attachment #8549977 - Flags: approval-mozilla-beta?
Attachment #8549977 - Flags: approval-mozilla-beta+
Attachment #8549977 - Flags: approval-mozilla-aurora?
Attachment #8549977 - Flags: approval-mozilla-aurora+
Flags: qe-verify-
No longer depends on: 1120030
You need to log in before you can comment on or make changes to this bug.