1120266 - Add Fragmented MP4 samples

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Jean-Yves Avenard [:jya]]

We don't currently have properly fragmented mp4 video samples for use with mse tests.

Comment 1

[Bobby Holley (:bholley)]

I currently have these in my tests for bug 1120030. We should probably just check those partly in, and comment out the tests that aren't passing.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Add fragmented mp4 sample videos

some samples.
bipbop.mp4 non-fragmented mp4 sample (audio/video combined: mp4a.40.2, avc1.4d4015)
bipbopinit.mp4, bipbop[0-13].m4s: fragmented mp4 (audio/video combined: mp4a.40.2, avc1.4d4015)
bipbop_videoinit.mp4, bipbop_video[0-13].m4s: fragmented mp4 (video only: avc1.4d4015)
bipbop_audioinit.mp4, bipbop_audio[0-13].m4s: fragmented mp4 (audio only: mp4a.40.2)

Comment 3

[Jean-Yves Avenard [:jya]]

(In reply to Bobby Holley (Busy with media, don't ask for DOM/JS/XPConnect things) from comment #1)
> I currently have these in my tests for bug 1120030. We should probably just
> check those partly in, and comment out the tests that aren't passing.

as you said, the gizmo are really crappy to test anything. You can't even tell for sure if the video has finished playing or played all its frames...
At least here you have a frame count showing, and an obvious way to tell A/V sync

Comment 4

[Jean-Yves Avenard [:jya]]

k17e: bholley placed his samples in test/mediasource/fgizmo 

let me know if you want to follow a similar path structure, than the media/test ones.

Comment 5

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8547262 [details] [diff] [review]
Add fragmented mp4 sample videos

I'll get cpearce to make the call on this patch.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8547262 [details] [diff] [review]
Add fragmented mp4 sample videos

Review of attachment 8547262 [details] [diff] [review]:
-----------------------------------------------------------------

I'm fine with these being in dom/media/test, but I wonder if it's more appropriate for them to be in dom/media/mediasource/test?

I'll punt this to cajbir, he's got a better idea how testing MSE should be done.

Comment 7

[Bobby Holley (:bholley)]

I think they should be in mediasource/test

Comment 8

[Jean-Yves Avenard [:jya]]

i put them in media/test because the EME mse files are there (gizmo-frag-*.mp4 etc)

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

Sure, the EME test files are in media/test because that's where all the EME mochitest HTML files are. If the EME mochitest files were in dom/media/eme/tests, would you put the MSE files in there? ;)

Comment 10

[Jean-Yves Avenard [:jya]]

Attachment: Add fragmented mp4 sample videos

Put bipbop.mp4 in media/test and all fragmented files in media/mediasource/test

Comment 11

[Jean-Yves Avenard [:jya]]

(In reply to Chris Pearce (:cpearce) from comment #9)
> Sure, the EME test files are in media/test because that's where all the EME
> mochitest HTML files are. If the EME mochitest files were in
> dom/media/eme/tests, would you put the MSE files in there? ;)

well, I would argue that eme tests should be withing mediasource test folder, as they are using mediasource.

You're one of us !

Comment 12

[Bobby Holley (:bholley)]

I'll take care of moving these into a subdirectory, adding them to mochitest.ini, and getting them checked in.

Comment 13

[Bobby Holley (:bholley)]

Attachment: Factor some machinery out of test_BufferingWait into mediasource.js and make it Promise-friendly. v1 r=jya

I'm going to take care of landing this bug, along with a patch that jya r+ed
in bug 1120030.

Comment 14

[Bobby Holley (:bholley)]

Attachment: Add fragmented mp4 sample videos. r=cajbir

Fixed up this patch a bit.

Comment 15

[Bobby Holley (:bholley)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/4c33a6636cc4
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a4f7c77bec12

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4c33a6636cc4
https://hg.mozilla.org/mozilla-central/rev/a4f7c77bec12

Comment 17

[Ralph Giles (:rillian)]

Comment on attachment 8549977 [details] [diff] [review]
Factor some machinery out of test_BufferingWait into mediasource.js and make it Promise-friendly. v1 r=jya

Approval Request Comment
[Feature/regressing bug #]: MSE
[User impact if declined]: Less consistent testing.
[Describe test coverage new/current, TreeHerder]: Landed on m-c.
[Risks and why]: Test-only.
[String/UUID change made/needed]: None.

Nominating both patches in this bug so we get similar test coverage on all branches.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/71eebeeac8f6
https://hg.mozilla.org/releases/mozilla-aurora/rev/04994d4c1a82

https://hg.mozilla.org/releases/mozilla-beta/rev/ff1b74ec9f19
https://hg.mozilla.org/releases/mozilla-beta/rev/53f55825252a