Closed
Bug 1120283
Opened 9 years ago
Closed 9 years ago
implement offset-{block,inline}-{start,end} logical properties
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: heycam, Assigned: heycam)
References
(Blocks 2 open bugs)
Details
(Keywords: dev-doc-complete)
Attachments
(2 files)
8.25 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
2.35 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8547372 -
Flags: review?(dbaron)
Assignee | ||
Updated•9 years ago
|
Attachment #8547372 -
Attachment description: 0030-Bug-1120283-Part-1-Implement-the-offset-block-inline.patch → Part 1: Implement the offset-{block,inline}-{start,end} logical properties.
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8547373 -
Flags: review?(dbaron)
Assignee | ||
Comment 3•9 years ago
|
||
Try run for my logical properties branch: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=9bf2ce4d8c8c
Updated•9 years ago
|
Attachment #8547372 -
Flags: review?(dbaron) → review+
Comment 5•9 years ago
|
||
Comment on attachment 8547373 [details] [diff] [review] Part 2: Tests. >+ if (/offset/.test(p)) { Maybe /^offset/ ?
Attachment #8547373 -
Flags: review?(dbaron) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Comment 6•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fa21a7e5c1d
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9232db22dcd https://hg.mozilla.org/integration/mozilla-inbound/rev/77dd16c161b1
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a9232db22dcd https://hg.mozilla.org/mozilla-central/rev/77dd16c161b1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment 9•9 years ago
|
||
Described the four new properties: https://developer.mozilla.org/en-US/docs/Web/CSS/offset-block-start https://developer.mozilla.org/en-US/docs/Web/CSS/offset-block-end https://developer.mozilla.org/en-US/docs/Web/CSS/offset-inline-start https://developer.mozilla.org/en-US/docs/Web/CSS/offset-inline-end https://developer.mozilla.org/en-US/Firefox/Releases/38#CSS Sebastian
Keywords: dev-doc-needed → dev-doc-complete
Comment 10•9 years ago
|
||
offset-inline-{start,end} don't seem to work as expected. Test case: data:text/html,<!DOCTYPE html><style>div{position:absolute;background:yellow;width:100px;height:100px;}p{position:absolute;margin:0;background:olive;offset-inline-start:0;}</style><div><p style="writing-mode:vertical-lr;">Test</p><p style="writing-mode:vertical-rl;">Test</p></div> I'd expect one paragraph being positioned at the bottom left of the yellow <div>. Sebastian
Flags: needinfo?(cam)
Comment 11•9 years ago
|
||
My fault. It works as expected. Same reasoning as in https://bugzilla.mozilla.org/show_bug.cgi?id=1083134#c59. Sebastian
Flags: needinfo?(cam)
Updated•7 years ago
|
Blocks: css-logical-props
You need to log in
before you can comment on or make changes to this bug.
Description
•