Closed Bug 1120283 Opened 8 years ago Closed 8 years ago

implement offset-{block,inline}-{start,end} logical properties

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38

People

(Reporter: heycam, Assigned: heycam)

References

(Blocks 2 open bugs)

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

Part 1: Implement the offset-{block,inline}-{start,end} logical properties.
8.25 KB, patch
dbaron
: review+
Details | Diff | Splinter Review
Part 2: Tests.
2.35 KB, patch
dbaron
: review+
Details | Diff | Splinter Review 
      No description provided.
Depends on: 1120284
Attachment #8547372 - Attachment description: 0030-Bug-1120283-Part-1-Implement-the-offset-block-inline.patch → Part 1: Implement the offset-{block,inline}-{start,end} logical properties.
Attached patch Part 2: Tests. — — Splinter Review 

        Attachment #8547373 -
        Flags: review?(dbaron)

        Attachment #8547372 -
        Flags: review?(dbaron) → review+

    
    

    
  
Comment on attachment 8547373 [details] [diff] [review]
Part 2: Tests.

>+      if (/offset/.test(p)) {

Maybe /^offset/ ?

        Attachment #8547373 -
        Flags: review?(dbaron) → review+

    
  
Keywords: dev-doc-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/a9232db22dcd
https://hg.mozilla.org/mozilla-central/rev/77dd16c161b1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
See Also:  → 1132859

    
    

    
  
offset-inline-{start,end} don't seem to work as expected.

Test case:
data:text/html,<!DOCTYPE html><style>div{position:absolute;background:yellow;width:100px;height:100px;}p{position:absolute;margin:0;background:olive;offset-inline-start:0;}</style><div><p style="writing-mode:vertical-lr;">Test</p><p style="writing-mode:vertical-rl;">Test</p></div>

I'd expect one paragraph being positioned at the bottom left of the yellow <div>.

Sebastian
Flags: needinfo?(cam)

    
    

    
  
My fault. It works as expected. Same reasoning as in https://bugzilla.mozilla.org/show_bug.cgi?id=1083134#c59.

Sebastian
Flags: needinfo?(cam)
Blocks: 1464782

          You need to log in
          before you can comment on or make changes to this bug.