1120295 - [EME] test case for "Clear Recent History" command

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

Follow-up bug for bug 1111788.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1120295_testcase-v1.patch

test case for "Clear Recent History" command.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8547382 [details] [diff] [review]
1120295_testcase-v1.patch

Review of attachment 8547382 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/gtest/TestGMPCrossOrigin.cpp
@@ +131,5 @@
> +  nsresult rv = aPath->GetDirectoryEntries(getter_AddRefs(iter));
> +  if (NS_FAILED(rv)) {
> +    return rv;
> +  }
> +

Nit: two blank lines here.

@@ +158,3 @@
>  template<typename T>
>  static nsresult
>  EnumerateDir(const nsACString& aDir, T&& aDirIter)

Probably a good idea to rename this to EnumerateGMPStorageDir to distinguish it from the EnumerateDir function you're adding here.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1120295_testcase-v2.patch

Fix nits in comment 2.

try: https://tbpl.mozilla.org/?tree=Try&rev=24b2af5f0ae6

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b5300132d105

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b5300132d105

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3c5c3aa669f6

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Beta patch

Patch for beta branch as part of EME platform uplift.

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8572314 [details] [diff] [review]
Beta patch

Requesting retroactive approval for Beta landing as part of EME platform uplift.

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8572314 [details] [diff] [review]
Beta patch

Approved for Beta as part of EME platform uplift.