Closed Bug 1120302 Opened 10 years ago Closed 10 years ago

HTTP proxy setting for APN is not applied

Categories

(Firefox OS Graveyard :: RIL, defect)

Product:
Firefox OS Graveyard
Component:
RIL
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.2+, firefox36 wontfix, firefox37 wontfix, firefox38 fixed, b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S4 (23jan)
Project Flags:
blocking-b2g 2.2+
Tracking Flags:
Tracking Status
firefox36 --- wontfix
firefox37 --- wontfix
firefox38 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: swu, Assigned: hchang)

Details

(Keywords: regression)

Attachments

(2 files)

Failure log
5.40 KB, text/plain
Details
Bug1120302.patch
2.77 KB, patch
vchang
: review+
bajaj
: approval-mozilla-b2g37+
Details | Diff | Splinter Review
Attached file Failure log —
Device: Flame Gecko: b8876c827edb Gaia: d102cc0a7a1f346531553bec64588eea9e4594eb When making data connection to APN which contains HTTP proxy, the proxy setting is not applied. Attached is the log with NetworkManager & NetworkService and debug enabled.
When the issue happened, the callback function of setDNS() was not called: https://dxr.mozilla.org/mozilla-central/source/dom/system/gonk/NetworkManager.js#1274
Assignee: nobody → hchang
Attached patch Bug1120302.patch — — Splinter Review
Attachment #8547484 - Flags: review?(vchang)
Comment on attachment 8547484 [details] [diff] [review] Bug1120302.patch Review of attachment 8547484 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks.
Attachment #8547484 - Flags: review?(vchang) → review+
(In reply to Vincent Chang[:vchang] from comment #4) > Comment on attachment 8547484 [details] [diff] [review] > Bug1120302.patch > > Review of attachment 8547484 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks good, thanks. Thanks for the review! Vincent
Keywords: checkin-needed
Component: General → RIL
https://hg.mozilla.org/mozilla-central/rev/409240119a2b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S4 (23jan)
Comment on attachment 8547484 [details] [diff] [review] Bug1120302.patch NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): HTTP Proxy User impact if declined: HTTP proxy will not applied when getting connected to network Testing completed: yes Risk to taking this patch (and alternatives if risky): No String or UUID changes made by this patch: No
Attachment #8547484 - Flags: approval-mozilla-b2g37?
triage: this is a regression. It's impact on the case when HTTP proxy is used.
blocking-b2g: --- → 2.2+
Keywords: regression
Attachment #8547484 - Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: