1120382 - Test failures in /testSecurity/testSSLDisabledErrorPage.js | testDisableSSL

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Mihaela Velimiroviciu (:mihaelav)]

Module:    testDisableSSL
Test:      /testSecurity/testSSLDisabledErrorPage.js
Failures:   
* The SSL error message contains disabled information - 'Nightly cannot guarantee the safety of your data on tlsv1-0.mozqa.com because it uses SSLv3, a broken security protocol.' should contain 'ssl_error_unsupported_version'
* The correct SSL error title is shown - 'Unable to Connect Securely' should equal 'Secure Connection Failed'
Branches:  Nightly (37.0)
Platforms: All

Reports: http://mozmill-daily.blargon7.com/#/remote/failure?app=Firefox&branch=All&platform=All&from=2015-01-01&to=2015-01-12&test=%2FtestSecurity%2FtestSSLDisabledErrorPage.js&func=testDisableSSL

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Teodor, is that one more change beside the fix you did on bug 1119784?

Comment 2

[Teodor Druta]

This seems like another failure. We should find the regression for this.

Comment 3

[Teodor Druta]

Here's the regressor:
https://bugzilla.mozilla.org/show_bug.cgi?id=1098371
https://hg.mozilla.org/mozilla-central/rev/816e1db8855f
https://hg.mozilla.org/mozilla-central/rev/6ed7044ca837

Comment 4

[Teodor Druta]

Attachment: fixssldisablemsg.patch

Here is the fix.

Comment 5

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8547515 [details] [diff] [review]
fixssldisablemsg.patch

Review of attachment 8547515 [details] [diff] [review]:
-----------------------------------------------------------------

::: firefox/tests/remote/testSecurity/testSSLDisabledErrorPage.js
@@ +66,1 @@
>                   "The SSL error message contains disabled information");

Please align the message.

Comment 6

[Teodor Druta]

Attachment: fixssldisablemsg.patch

Fixed message alignment.

Comment 7

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8547525 [details] [diff] [review]
fixssldisablemsg.patch

Review of attachment 8547525 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/qa/mozmill-tests/rev/ce1dd09d8465 (default)

Thanks Teo!

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Teodor Druta from comment #3)
> Here's the regressor:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1098371

Thanks, and please really add it to the dependency list in the future.