1120470 - Handle uncaught promise rejections in protocol.js

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Eddy Bruel [:ejpbruel]]

While attempting to remove the deprecated-sync-thenables from protocol.js (bug 1096490), I ran into a unhandled promise rejection within protocol.js. The problem seems to be that we're trying to send a packet after the connection has closed. Protocol.js needs to report these errors rather than silently ignore them.

Comment 1

[Eddy Bruel [:ejpbruel]]

Attachment: Handle uncaught promise rejections

Comment 2

[Eddy Bruel [:ejpbruel]]

Try run for the above patch:
https://tbpl.mozilla.org/?tree=Try&rev=51cda441842a

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8547630 [details] [diff] [review]
Handle uncaught promise rejections

Review of attachment 8547630 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/protocol.js
@@ +1148,5 @@
>      } else {
>        this.actor().then(actorID => {
>          packet.to = actorID;
>          this.conn._transport.send(packet);
> +      }).then(null, Cu.reportError);

This should be:

    e => DevToolsUtils.reportException("Front.prototype.send", e)

(Sorry for the drive-by)

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(Instead of `Cu.reportError`)

Comment 5

[Dave Camp (:dcamp)]

Comment on attachment 8547630 [details] [diff] [review]
Handle uncaught promise rejections

r+ with fitzgen's comment addressed.

Comment 6

[Eddy Bruel [:ejpbruel]]

Try push for patch with comments addressed, just in case:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=096a5ed7a9aa

Comment 7

[Eddy Bruel [:ejpbruel]]

Try push looks green, but just discovered that another try push caused oranges on windows because I forgot to require DevToolsUtils. Here's another try push that includes windows builds with that problem addressed:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=0f9945a7f502

Comment 8

[Eddy Bruel [:ejpbruel]]

Try push looks green, pushing to fx-team:
https://hg.mozilla.org/integration/fx-team/rev/e5540f8b4a2a

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e5540f8b4a2a