1120480 - taken_by returns a user id that we can't compare

Status: RESOLVED FIXED

(support.mozilla.org :: Questions, task)

Description

[Anthony Ricaud (:rik)]

We need to compare taken_by with the current user. We don't know the user id and the question api returns one.

So we either need a user id returned by the User API or a username returned by the Question API.

Comment 1

[Michael Cooper [:mythmon]]

This is an easy fix. I'll do it now.

Comment 2

[Michael Cooper [:mythmon]]

This PR makes it so all references to users on the question and answer serializers use `{username: 'bob', display_name: 'Bobert'}` style for ever field that references a user.

https://github.com/mozilla/kitsune/pull/2305

Comment 3

[Cor vL (cor-el)]

Will this work for the solver_id as well and give the username instead of the id?

Comment 4

[Michael Cooper [:mythmon]]

I'll make a pass to make sure that users aren't referenced by id in output or in filtering. You should be able to use queries like /api/2/question/?solver=mythmon. If it isn't working like that today, that's a bug.

Comment 5

[Cor vL (cor-el)]

metadata currently shows {"name":"solver_id","value":"997124"} if the thread is solved ("is_solved":true and "solution": not null)
It would be nice if this could be the username

Comment 6

[Michael Cooper [:mythmon]]

a) Those fields shouldn't be in metadata, but should be full fledged fields of their own.
b) You're right. And in fact a commit I have written by haven't deployed yet turns solver into an object that has username and display_name.

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod:

https://github.com/mozilla/kitsune/commit/c3dc6db867ecc25a86104d089cbb848afab1c783
https://github.com/mozilla/kitsune/commit/1a08263c9ebdfa44bc6b39d6f5118d1c75bf66e1