1120613 - "Failure arg 6 [nsIContentPolicy.shouldLoad]" in RemoteAddonsParent.jsm with e10s

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[(no longer active)]

I get a lot of errors in the error console like this when I use the browser:

[Exception... "Failure arg 6 [nsIContentPolicy.shouldLoad]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/RemoteAddonsParent.jsm :: ContentPolicyParent.shouldLoad/result< :: line 149"  data: no]

It's hard to say what's going on here but the 7th argument here is not an nsIPrincipal, that part is for sure!

Comment 1

[Dave Townsend [:mossop]]

No idea where we're tracking bugs in the shims

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

Ugh. This should have been so much easier to find, but I got thrown off
by the exact bug that this patch fixes. billm pointed out that we CPOW
functions, so all of this code needs to deal with them anyway, but we
especially need to handle the case of HTML <object> and <embed>, which
both have typeof == "function".

I thought of naming the function isWrappable but left it for now.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Without this patch, adblock won't block Flash elements.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8552726 [details] [diff] [review]
patch v1

Review of attachment 8552726 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this!

::: toolkit/components/addoncompat/Prefetcher.jsm
@@ +83,5 @@
>   */
>  
>  const PREF_PREFETCHING_ENABLED = "extensions.interposition.prefetching";
>  
> +function treatAsObject(v) {

How about isPrimitive (and reverse the sense)?

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1.1

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/27d44f100d4e

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/27d44f100d4e