"Failure arg 6 [nsIContentPolicy.shouldLoad]" in RemoteAddonsParent.jsm with e10s

RESOLVED FIXED in mozilla38

Status

()

Toolkit
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Away for a while, Assigned: mrbkap)

Tracking

unspecified
mozilla38
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(e10s?)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
I get a lot of errors in the error console like this when I use the browser:

[Exception... "Failure arg 6 [nsIContentPolicy.shouldLoad]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/RemoteAddonsParent.jsm :: ContentPolicyParent.shouldLoad/result< :: line 149"  data: no]

It's hard to say what's going on here but the 7th argument here is not an nsIPrincipal, that part is for sure!
No idea where we're tracking bugs in the shims
Component: Add-ons Manager → General
Flags: needinfo?(mrbkap)
(Assignee)

Comment 2

3 years ago
Created attachment 8552726 [details] [diff] [review]
patch v1

Ugh. This should have been so much easier to find, but I got thrown off
by the exact bug that this patch fixes. billm pointed out that we CPOW
functions, so all of this code needs to deal with them anyway, but we
especially need to handle the case of HTML <object> and <embed>, which
both have typeof == "function".

I thought of naming the function isWrappable but left it for now.
Attachment #8552726 - Flags: review?(wmccloskey)
(Assignee)

Comment 3

3 years ago
Without this patch, adblock won't block Flash elements.
Assignee: nobody → mrbkap
Flags: needinfo?(mrbkap)
Comment on attachment 8552726 [details] [diff] [review]
patch v1

Review of attachment 8552726 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this!

::: toolkit/components/addoncompat/Prefetcher.jsm
@@ +83,5 @@
>   */
>  
>  const PREF_PREFETCHING_ENABLED = "extensions.interposition.prefetching";
>  
> +function treatAsObject(v) {

How about isPrimitive (and reverse the sense)?
Attachment #8552726 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 5

3 years ago
Created attachment 8552743 [details] [diff] [review]
patch v1.1
Attachment #8552726 - Attachment is obsolete: true
Attachment #8552743 - Flags: review+
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/27d44f100d4e
https://hg.mozilla.org/mozilla-central/rev/27d44f100d4e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.