Closed
Bug 1120685
Opened 11 years ago
Closed 11 years ago
pk11cert.c: warning: variable ‘swapNickname’ [and] ‘isFortezzaRootCA’ set but not used [-Wunused-but-set-variable]
Categories
(NSS :: Libraries, defect)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
3.17.4
People
(Reporter: Cykesiopka, Assigned: Cykesiopka)
Details
Attachments
(1 file)
|
1.93 KB,
patch
|
KaiE
:
review+
|
Details | Diff | Splinter Review |
I get the following build warnings on Ubuntu 14.10 with GCC 4.9.1:
> pk11cert.c: In function ‘PK11_MakeCertFromHandle’:
> pk11cert.c:297:12: warning: variable ‘swapNickname’ set but not used [-Wunused-but-set-variable]
> PRBool swapNickname = PR_FALSE;
> ^
> pk11cert.c:296:12: warning: variable ‘isFortezzaRootCA’ set but not used > [-Wunused-but-set-variable]
> PRBool isFortezzaRootCA = PR_FALSE;
> ^
It appears the last uses of these variables was removed here:
https://hg.mozilla.org/projects/nss/diff/73248dd6330b/security/nss/lib/pk11wrap/pk11cert.c#l1.364
I'll attach a patch that removes the variables shortly.
| Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8547818 -
Flags: review?(kaie)
Comment 2•11 years ago
|
||
Comment on attachment 8547818 [details] [diff] [review]
bug1120685_rm-swapNickname-isFortezzaRootCA-pk11cert.c_v1.patch
r=kaie
Attachment #8547818 -
Flags: review?(kaie) → review+
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.18
You need to log in
before you can comment on or make changes to this bug.
Description
•