1120729 - Support other locales for search engines

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Brian Nicholson (:bnicholson)]

Currently, we just hardcode en-US as the search localization directory.

Comment 1

[Karen Rudnitski [:kar]]

given we're looking at launching in a handful of countries upon v1.0 release (Germany and Canada, for instance), we'll need to get this localize-able. We want to ensure we have the flexibility to modify our search providers based on locale (since en-US would have a different default to de which would have a different default to ch-CN, for instance)

Comment 2

[Richard Newman [:rnewman]]

Also switching between partners based on geo. Need to thrash this out.

Comment 3

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/423

Even though nothing final has been decided in the search discussions, mfinkle suggested landing this and incrementing as we go. Geo-based search is likely orthogonal to these changes anyway.

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8604393 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/423

LGTM

If you decide to do use .lproj files, we can automate the import if needed. Also doing the same for strings.