Support other locales for search engines

RESOLVED FIXED

Status

()

Firefox for iOS
Home screen
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bnicholson, Assigned: bnicholson)

Tracking

unspecified
All
iOS 8
Dependency tree / graph

Firefox Tracking Flags

(fennec+)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Currently, we just hardcode en-US as the search localization directory.
(Assignee)

Updated

3 years ago
Assignee: bnicholson → nobody
(Assignee)

Updated

3 years ago
tracking-fennec: --- → ?
given we're looking at launching in a handful of countries upon v1.0 release (Germany and Canada, for instance), we'll need to get this localize-able. We want to ensure we have the flexibility to modify our search providers based on locale (since en-US would have a different default to de which would have a different default to ch-CN, for instance)
tracking-fennec: ? → +
OS: iOS 7 → iOS 8
Summary: Support other localizations for search engines → Support other locales for search engines
Also switching between partners based on geo. Need to thrash this out.
(Assignee)

Updated

3 years ago
Status: ASSIGNED → NEW
(Assignee)

Updated

3 years ago
Assignee: nobody → bnicholson
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
Created attachment 8604393 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/423

Even though nothing final has been decided in the search discussions, mfinkle suggested landing this and incrementing as we go. Geo-based search is likely orthogonal to these changes anyway.
Attachment #8604393 - Flags: review?(sarentz)
Comment on attachment 8604393 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/423

LGTM

If you decide to do use .lproj files, we can automate the import if needed. Also doing the same for strings.
Attachment #8604393 - Flags: review?(sarentz) → review+
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Depends on: 1164145
You need to log in before you can comment on or make changes to this bug.