Closed Bug 1120799 Opened 9 years ago Closed 9 years ago

(App-grouping) Dragging an big expanded group, the below group is not shown in screen

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.1 unaffected, b2g-v2.1S unaffected, b2g-v2.2 verified, b2g-master verified)

Status:
VERIFIED FIXED
Milestone:
2.2 S5 (6feb)
Tracking Flags:
Tracking Status
b2g-v2.1 --- unaffected
b2g-v2.1S --- unaffected
b2g-v2.2 --- verified
b2g-master --- verified

People

(Reporter: hcheng, Assigned: cwiiis)

References

Details

(Keywords: polish, Whiteboard: [systemsfe])

Attachments

(1 file)

Don't leave space when dragging an expanded group
46 bytes, text/x-github-pull-request
kgrandon
: review+
bajaj
: approval-gaia-v2.2+
Details | Review 
After user long-press an expanded and big group to drag it, this group collapses, and the other group under the tapped one keeps its original place and is not shown on the screen. see [1]

This is not a problem when long-pressing a small group, but in this case, user cannot drag it downward efficiently.

[1] video: https://www.youtube.com/watch?v=RIXTGh8uka4&feature=youtu.be
Blocks: app-grouping
blocking-b2g: --- → 2.2?
Flags: needinfo?(chrislord.net)
Whiteboard: [systemsfe]
Assignee: nobody → chrislord.net
Status: NEW → ASSIGNED
Flags: needinfo?(chrislord.net)
Keywords: polish
blocking-b2g: 2.2? → ---
No test because the test I wrote hits some Marionette bug :| Will file a separate bug for that, but if you could excuse it this time, that'd be great :)
Attachment #8555901 - Flags: review?(kgrandon)
Depends on: 1126848
Comment on attachment 8555901 [details] [review]
Don't leave space when dragging an expanded group

Makes sense and seems to work well. Thanks!
Attachment #8555901 - Flags: review?(kgrandon) → review+
In master: https://github.com/mozilla-b2g/gaia/commit/09f243bbc3e5d7bf85b072e82861b5f8700f1521
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-b2g-v2.1: --- → unaffected
status-b2g-v2.1S: --- → unaffected
status-b2g-v2.2: --- → affected
status-b2g-master: --- → fixed
Resolution: --- → FIXED
Comment on attachment 8555901 [details] [review]
Don't leave space when dragging an expanded group

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature implementation.
[User impact] if declined: Not a very good experience when using home screen groups. Nicer with this patch.
[Testing completed]: Manual, integration test is coming in another bug and can be uplifted.
[Risk to taking this patch] (and alternatives if risky): Fairly low risk (just 3 lines).
[String changes made]: None.
Attachment #8555901 - Flags: approval-gaia-v2.2?(bbajaj)
Attachment #8555901 - Flags: approval-gaia-v2.2?(bbajaj) → approval-gaia-v2.2+
This issue is verified fixed on Flame 2.2 and Master.

Result: After collapsing a big group, the group below is showing properly on the edit mode.
 
Device: Flame 2.2 (319mb, full flash)
Build ID: 20150206002505
Gaia: a52999ce7f783177deb17e267bf003a53e6fde06
Gecko: 01446d5231ef
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37

Device: Flame Master (319mb, full flash)
Build ID: 20150206010204
Gaia: 94af4b42d2ace6c9f38f31de77240604fac68af1
Gecko: 7c5f187b65bf
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: