1120897 - [Loop] Notification isn't shown name/surname about contact joins to room.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Loli (:lolimartinezcr)]

Flame
2.0
Gecko-5f9dc54
Gaia-31d6c94
Loop version: master/51a04dd

This bug is reproducible is this scenarios:
-Scenario 1:
User A logged in Mobile Loop application.
User B logged in Desktop Loop application.

-Scenario 2:
User A logged in Mobile Loop application.
User B logged in Mobile Loop application.

Pre-requisites:
User A logged in Loop application, has created and shared a room with User B.
Scenario 1: User B saved in contact application with name, surname and email.
Scenario 2: User B saved in contact application with name, surname and phone number.

STRs:
1. Owner is already in the room.
2. User A keeps the App in Background.
3. User B joins the room shared by A. 

Actual result:
Scenario 1: User A receives a notification saying "*Guest* has joined".
Scenario 2: User A receives a notification sayint "*+346xxxxxxxx* has joined".

Expected result:
User A receives a notification saying "[Name/Surname] has joined".

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8549486 [details] [review]
Github pull request

LGTM. r=me, with nits addressed please.

Thanks for taking care of it Cristian!

Comment 3

[Cristian Rodriguez (:crdlc)]

master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/8cc837dea9278c90bef0b5fd08613cbf01834785

Comment 4

[isabelrios]

Now the contact name/surname is shown in a notification received.
Verified on Fire E 2.0
Loop 1.1.1/d4d6d37