1120948 - [Loop] New name in room isn't visible in rooms list of invited user.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Loli (:lolimartinezcr)]

Flame
2.0
User
Gecko-5f9dc54
Gaia-31d6c94
Loop version: master/51a04dd

Prerequisites:
-Mobile user "A" is the owner and has created a room previously and shared it with Mobile user "B".
- Mobile user "B" has joined to room and a few seconds after he has leave the room. In user B the room list appears the room.

STRs:
1. User A,  tap on the room created by "A" in rooms list.
2. Tap on 'Edit' button.
3. Change the room's name by adding or deleting any character, then tap on Save.
4. Go back to Rooms list by tapping on back button (<).
5. Again, user B joins to room tapping  on the room created by "A" in her rooms list. ER1
6. Again, user B leaves to room. ER2

Expected result:
ER1. When user B is joined to room, he can read the new name in the room .
ER2. When user B leaves the room and go back to room list, he can see the new name the room in rooms list.

Actual result:
When user B is joined to room, he can read the new name in room list, but when user leaves to room and go back to room list, he *can't* see the new name the room in rooms list.

Comment 1

[Loli (:lolimartinezcr)]

Attachment: IMG_13012015_152852.png

Comment 2

[Loli (:lolimartinezcr)]

Also this bug is reproducible

Prerequisite
-Desktop user "A" is the owner and has created a room previously and shared it with Mobile user "B".
- Mobile user "B" has joined to room and a few seconds after he has leave the room. In user B the room list appears the room.

STRs:
1. User A,  tap on the room created by "A" in rooms list.
2. Put cursor in box about name (See image: IMG_13012015_152852)
3. Change the room's name by adding or deleting any character, then tap Intro in keyboard.
5. Again, user B joins to room tapping  on the room created by "A" in her rooms list. ER1
6. Again, user B leaves to room. ER2

Expected result:
ER1. When user B is joined to room, he can read the new name in the room .
ER2. When user B leaves the room and go back to room list, he can see the new name the room in rooms list.

Actual result:
When user B is joined to room, he can read the new name in room list, but when user leaves to room and go back to room list, he *can't* see the new name the room in rooms list.

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Very easy solution, the room manager calls to CallLog.addRoom(room) for invited rooms. It works only the first time when the room is not in the calllog. Once an item is already stored in the DB and we try to add it again, it fails. So in this case we will update the item. I decided update the room when the addition fails in the calllog, this means that the addRoom is like a "put" action. Now it works like a charm without touching the room manager logic. Thanks Borja for taking a look at this patch.

Comment 4

[Borja Salguero [:borjasalguero]]

Comment on attachment 8548259 [details] [review]
Github pull request

Great job Cristian!

Comment 5

[Cristian Rodriguez (:crdlc)]

master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/ccc11ef00634da2505d597f40b86691ece5c760a

Comment 6

[isabelrios]

Re-named rooms appear in room list correctly
Verified on Fire E 2.0
Loop version:1.1.1/d4d6d37