112103 - Don't allow copy/move/drag and drop to read-only folders.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[scottputterman]

This is one of the tasks for shared folders.  Read-only folders can't have
messages moved or copied into them.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

check acl as well as noselect to see if we can drop messages on a folder.

Comment 2

[David :Bienvenu]

Navin, can I get an r=? thx.

Comment 3

[Navin Gupta]

Comment on attachment 67459 [details] [diff] [review]
proposed fix

looks good, r=naving

Comment 4

[David :Bienvenu]

fix checked in.

Comment 5

[Karen Huang]

Verified Windows 03-25-10-trunk build on Windows 2000:
We are not allowing copy/move and drag&drop to read-only folders now.

But, there is one thing that I need to confirm with David:
David, from the copy message and move message memu items:
Looks like we are taking out of read-only folders from copy/move message menu 
items instead of disable them on the copy/move menu items(as 4.7x).....are these 
correct?

Comment 6

[David :Bienvenu]

Karen, I don't know what the front end menu code is doing, or should be doing. I
didn't do anything to the menu code - I just implemented a backend routine that
says the folder is readonly, and can't have messages dropped into it. It sounds
like we're not putting readonly folders into the menu. If that's wrong, that
would be a different, front end bug. I'd need to try it myself to see what's
going on. The one thing that would worry me is if a parent folder is readonly,
but its children are not, do we not put any of them in the menu?

Comment 7

[David :Bienvenu]

I see readonly folders in the menu, but the File Here choice is disabled, as it
should be, so everything seems fine to me.

Comment 8

[jglick]

>I see readonly folders in the menu, but the File Here choice is disabled, as it
should be, ...

Agree. If the folder has no children and is read only, it should be visible, but 
disabled.