1121032 - disable "Shipped!" button when it wouldn't be accepted anyways

Status: RESOLVED FIXED

(Release Engineering :: Applications: Shipit, defect)

Description

[[e-mail] (:bhearsum)]

Eg, if Firefox-35.0-build3 is shipped already, we shouldn't have the button for Firefox-35.0-build1 or build2.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: 0001-Bug-1121032-Do-not-display-the-button-Shipped-if-we-.patch

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8548975 [details] [diff] [review]
0001-Bug-1121032-Do-not-display-the-button-Shipped-if-we-.patch

http://git.mozilla.org/?p=build/release-kickoff.git;a=commitdiff;h=c7f959f5eed87c280a26886183481bd347fcb1b0

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

It looks this got pushed into production at some point, because we have "Other build shipped" on https://ship-it.mozilla.org/releases.html#ReviewedRunning now. But there might be some fallout.

If you filter on 36.0b1 you'll see this:
   Release                Status         Actual "Shipped?"         Expected "Shipped?'
  Firefox-36.0b1-build2   Post Release   Other build shipped       Shipped + 'Not shipped' button
  Fennec-36.0b1-build1    Post Release   Other build shipped       Shipped + 'Not shipped' button
  Firefox-36.0b1-build1   Post Release   Other build shipped       Other build shipped

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Indeed. Seems broken :/
The thing is that Status == "Post Release" while I was expecting "postrelease".
I am not sure why... (I am using sqlite)

Ben, does it ring a bell?

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #4)
> Indeed. Seems broken :/
> The thing is that Status == "Post Release" while I was expecting
> "postrelease".
> I am not sure why... (I am using sqlite)
> 
> Ben, does it ring a bell?

"postrelease" looks to be the short version that's stored in the database. "Post Release" is the pretty version that gets displayed: http://git.mozilla.org/?p=build/release-kickoff.git;a=blob;f=kickoff/views/status.py;h=859357f0730ee46055fae4915c31b4ee3d9db324;hb=HEAD#l88

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Attachment: 0001-Extends-the-check-to-another-writing-of-the-status.patch

I am not sure why but with sqlite, I had postrelease, with MySQL, I get "Post Release".
I don't think you will be happy with my lazy workaround. Maybe you have a better idea.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

http://git.mozilla.org/?p=build/release-kickoff.git;a=commit;h=0482d5772f916b422781fc17c704e09f232e1cff

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Looks fine now.

Comment 9

[Rail Aliiev [:rail]]

I think this is fixed.