1121043 - Investigate using RTPsender in tab switching design

Status: RESOLVED WORKSFORME

(Core :: WebRTC: Audio/Video, defect)

Description

[:shell escalante]

When going through Bug 1099241 - [meta] Implement basic sharing in rooms - it was discussed that it a desired UX is to be able to share a tab and then change tabs while sharing.  Randell and Maire were there- and called out that with current implementation of tab sharing there would be a delay of several seconds.

potentially RTPsender could be leveraged to avoid the delay.  Randell was going to investigate.  Need to know feasibility, impact to current Tabs code, and anything we'd need from TokBox SDK described (potentially not all in same bug)

Comment 1

[Maire Reavy [:mreavy]]

I've asked jib to take the lead on this.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Here's a screen-sharing tab-flip test in Nightly: http://jsfiddle.net/jib1/o5dcc4mr

For it to work, you must add "jsfiddle.net" to media.getusermedia.screensharing.allowed_domains. You might also want to set media.navigator.permission.disabled as well. Be careful!

Currently it flips between fullscreen and a random window, as AFAIK there's no way to specify different windows or tabs yet.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

You have to set  media.navigator.permission.disabled to true, since jsfiddle doesn't seem to support https:

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

(In reply to Randell Jesup [:jesup] from comment #3)
> You have to set  media.navigator.permission.disabled to true, since jsfiddle
> doesn't seem to support https:

Odd, works for me with a little work: I just have to change "No window" to some listed window and "No Screen" to "Entire Screen" in the permission dialogs.

E.g. to flip between two windows, s/"screen"/"window"/ in the example, hit Run + [Start!] and then pick a different window in each doorhanger that comes up.

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: tabflip.html - shows flipping between screensharing sources in Nightly

(In reply to Randell Jesup [:jesup] from comment #3)
> You have to set  media.navigator.permission.disabled to true, since jsfiddle
> doesn't seem to support https:

Randell is right (I forgot I had disabled code locally), here's the same test as a bugzilla attachment if you want to play with the doorhangers or not turn off permissions. You'll need to add "*.bugzilla.mozilla.org" to media.getusermedia.screensharing.allowed_domains in about:config if you haven't already.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

So did we decide not to use this? Do we still intend to in the future?

Comment 7

[Mark Banner (:standard8)]

We're using this - this was just an experiment to confirm it worked seamlessly.

I think we can call this WFM now.