1121176 - Steeplechase test broken by bug 1091242

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Nils Ohlmeier [:drno]]

Bug 1091242 introduces a new bug in our tests which is only exposed on steeplechase.

On steeplechase pcLocal passes in an undefined reference to checkStatsIceConnections().

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: bug_1121176_proper_answer_for_steeplechase.patch

test.originalAnswer in case of steeplechase is only set on the pcRemote side. This passes the proper reference to test._remote_answer for the pcLocal side.

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8548442 [details] [diff] [review]
bug_1121176_proper_answer_for_steeplechase.patch

Review of attachment 8548442 [details] [diff] [review]:
-----------------------------------------------------------------

Do we also need to fix PC_REMOTE_CHECK_ICE_CONNECTIONS?

Comment 3

[Nils Ohlmeier [:drno]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4645389572e

Comment 4

[Nils Ohlmeier [:drno]]

(In reply to Byron Campen [:bwc] from comment #2)
> Do we also need to fix PC_REMOTE_CHECK_ICE_CONNECTIONS?

No we don't because pcRemote calls setRemoteDescription() which actually sets test.originalAnswer.

Comment 5

[Byron Campen [:bwc]]

Comment on attachment 8548442 [details] [diff] [review]
bug_1121176_proper_answer_for_steeplechase.patch

Review of attachment 8548442 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 6

[Nils Ohlmeier [:drno]]

I don't see any new problems in the test run.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae930ec86dbd

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ae930ec86dbd

Comment 9

[Nils Ohlmeier [:drno]]

Comment on attachment 8548442 [details] [diff] [review]
bug_1121176_proper_answer_for_steeplechase.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1091242 introduced a bug in the WebRTC tests.
[User impact if declined]: None.
[Describe test coverage new/current, TreeHerder]: Currently without this patch all test executions in the WebRTC QA lab fail to finish. Manual verification of the fix has been done.
[Risks and why]: Almost no risk.
[String/UUID change made/needed]: N/A

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8548442 [details] [diff] [review]
bug_1121176_proper_answer_for_steeplechase.patch

Aurora+

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cac072915483