Closed Bug 1121176 Opened 5 years ago Closed 5 years ago

Steeplechase test broken by bug 1091242

Categories

(Core :: WebRTC, defect)

37 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox35 --- unaffected
firefox36 --- unaffected
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: drno, Assigned: drno)

Details

Attachments

(1 file)

Bug 1091242 introduces a new bug in our tests which is only exposed on steeplechase.

On steeplechase pcLocal passes in an undefined reference to checkStatsIceConnections().
test.originalAnswer in case of steeplechase is only set on the pcRemote side. This passes the proper reference to test._remote_answer for the pcLocal side.
Attachment #8548442 - Flags: review?(docfaraday)
Comment on attachment 8548442 [details] [diff] [review]
bug_1121176_proper_answer_for_steeplechase.patch

Review of attachment 8548442 [details] [diff] [review]:
-----------------------------------------------------------------

Do we also need to fix PC_REMOTE_CHECK_ICE_CONNECTIONS?
(In reply to Byron Campen [:bwc] from comment #2)
> Do we also need to fix PC_REMOTE_CHECK_ICE_CONNECTIONS?

No we don't because pcRemote calls setRemoteDescription() which actually sets test.originalAnswer.
Comment on attachment 8548442 [details] [diff] [review]
bug_1121176_proper_answer_for_steeplechase.patch

Review of attachment 8548442 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8548442 - Flags: review?(docfaraday) → review+
I don't see any new problems in the test run.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ae930ec86dbd
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment on attachment 8548442 [details] [diff] [review]
bug_1121176_proper_answer_for_steeplechase.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1091242 introduced a bug in the WebRTC tests.
[User impact if declined]: None.
[Describe test coverage new/current, TreeHerder]: Currently without this patch all test executions in the WebRTC QA lab fail to finish. Manual verification of the fix has been done.
[Risks and why]: Almost no risk.
[String/UUID change made/needed]: N/A
Attachment #8548442 - Flags: approval-mozilla-aurora?
Comment on attachment 8548442 [details] [diff] [review]
bug_1121176_proper_answer_for_steeplechase.patch

Aurora+
Attachment #8548442 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.