If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Don't harcode the system app origin in touch-events.js

RESOLVED FIXED

Status

Firefox OS
Runtime
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: fabrice, Assigned: fabrice)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Because it can change...
(Assignee)

Updated

3 years ago
Blocks: 1115098
(Assignee)

Comment 1

3 years ago
Created attachment 8548489 [details] [diff] [review]
touch-events.patch
Attachment #8548489 - Flags: review?(poirot.alex)
Comment on attachment 8548489 [details] [diff] [review]
touch-events.patch

Review of attachment 8548489 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/touch-events.js
@@ +72,5 @@
> +      try {
> +        systemOrigin = Services.io.newURI(
> +          Services.prefs.getCharPref("b2g.system_manifest_url"), null, null)
> +          .prePath;
> +      } catch(e) {}

We may want to compute systemOrigin once, during startup, instead of doing it on each click!
Attachment #8548489 - Flags: review?(poirot.alex) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/b2g-inbound/rev/a1344737184b
https://hg.mozilla.org/mozilla-central/rev/a1344737184b
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.