Closed Bug 1121228 Opened 5 years ago Closed 5 years ago

Show default search engine first

Categories

(Firefox for iOS :: Home screen, defect)

All
iOS 7
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review
Like Desktop and Android, the default search engine should be listed first.
Attached file Pull request
Attachment #8548490 - Flags: review?(sarentz)
Keep in mind that Desktop and Android have a way to order more than a single engine as "first". On Android we set the order for the top 3 engines.
Also, this is locale dependent and distribution dependent. Things to think about.
Added a few small comments to the PR.
(In reply to Mark Finkle (:mfinkle) from comment #3)
> Also, this is locale dependent and distribution dependent. Things to think
> about.

The locale we can look at for sure but Distribution is an interesting one. Because you can only upload one binary to the App Store. (Is that different on Google Play?)

I wonder if there is a 'receipt' left on the device in which we can from what App Store the app was downloaded.
(In reply to Stefan Arentz [:st3fan] from comment #5)
> (In reply to Mark Finkle (:mfinkle) from comment #3)
> > Also, this is locale dependent and distribution dependent. Things to think
> > about.
> 
> The locale we can look at for sure but Distribution is an interesting one.
> Because you can only upload one binary to the App Store. (Is that different
> on Google Play?)

We only have one core binary on the Play Store too. We allow Distributions via pre-installs (might not be applicable to iOS) and over-the-air-download of configuration files, which might be possible.

We're not ready to focus on making Distributions work right now, I just wanted is to be aware that they could happen.
Depends on: 1121628
Comment on attachment 8548490 [details] [review]
Pull request

LGTM
Attachment #8548490 - Flags: review?(sarentz) → review+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.