[Loop] Audio/Video codec identification for Rooms

RESOLVED FIXED

Status

Firefox OS
Gaia::Loop
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Oscar Patiño González, Assigned: Oscar Patiño González)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Right now AV codec identification is implemented for conversations but not for Rooms. We are going to identify the A&V codec used for a Room's session.
(Assignee)

Updated

4 years ago
Assignee: nobody → opatinobugzilla
(Assignee)

Updated

4 years ago
OS: Windows 7 → Gonk (Firefox OS)
Hardware: x86_64 → ARM
(Assignee)

Comment 1

4 years ago
Created attachment 8551366 [details] [review]
proposed patch
Attachment #8551366 - Flags: review?(josea.olivera)
Attachment #8551366 - Flags: review?(carmen.jimenezcabezas)
Comment on attachment 8551366 [details] [review]
proposed patch

Left a few comments on the PR. Please address them and request review at me once you are done. Thanks Oscar!.
Attachment #8551366 - Flags: review?(josea.olivera)
Comment on attachment 8551366 [details] [review]
proposed patch

I think one reviewer is enough.
I have only one question. don't we want differentiate between the count for codeVideo used in the room and in the call? If this is the point, we should use different count variables names
Flags: needinfo?(opatinobugzilla)
Attachment #8551366 - Flags: review?(carmen.jimenezcabezas)
(Assignee)

Comment 4

4 years ago
It's better to know the codec used for the communication than the communication type( conversation room).
Flags: needinfo?(opatinobugzilla)
(Assignee)

Updated

4 years ago
Attachment #8551366 - Flags: review?(josea.olivera)
Comment on attachment 8551366 [details] [review]
proposed patch

Left some comments on the pull request. Please, have a look at them and request review at me again once you address all of them. Thanks!
Attachment #8551366 - Flags: review?(josea.olivera)
(Assignee)

Updated

4 years ago
Attachment #8551366 - Flags: review?(josea.olivera)
Comment on attachment 8551366 [details] [review]
proposed patch

Left some comments on the pull request. Please, have a look at them and request review at me again once you address all of them. Thanks!
Attachment #8551366 - Flags: review?(josea.olivera)
(Assignee)

Updated

4 years ago
Attachment #8551366 - Flags: review?(josea.olivera)
Comment on attachment 8551366 [details] [review]
proposed patch

This is looking great. I'd like you to address the comments I made in the pull request before r+'ing this patch. Please, request review at me again once you address all of them.
Attachment #8551366 - Flags: review?(josea.olivera) → feedback+
(Assignee)

Updated

4 years ago
Attachment #8551366 - Flags: review?(josea.olivera)
Comment on attachment 8551366 [details] [review]
proposed patch

LGTM, r=me with comments addressed. Please address them and land at will. Thanks Oscar!
Attachment #8551366 - Flags: review?(josea.olivera) → review+
Depends on: 1127789
You need to log in before you can comment on or make changes to this bug.