1121338 - [Loop] Audio/Video codec identification for Rooms

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Oscar Patiño González]

Right now AV codec identification is implemented for conversations but not for Rooms. We are going to identify the A&V codec used for a Room's session.

Comment 1

[Oscar Patiño González]

Attachment: proposed patch

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8551366 [details] [review]
proposed patch

Left a few comments on the PR. Please address them and request review at me once you are done. Thanks Oscar!.

Comment 3

[Carmen Jimenez Cabezas]

Comment on attachment 8551366 [details] [review]
proposed patch

I think one reviewer is enough.
I have only one question. don't we want differentiate between the count for codeVideo used in the room and in the call? If this is the point, we should use different count variables names

Comment 4

[Oscar Patiño González]

It's better to know the codec used for the communication than the communication type( conversation room).

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8551366 [details] [review]
proposed patch

Left some comments on the pull request. Please, have a look at them and request review at me again once you address all of them. Thanks!

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8551366 [details] [review]
proposed patch

Left some comments on the pull request. Please, have a look at them and request review at me again once you address all of them. Thanks!

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8551366 [details] [review]
proposed patch

This is looking great. I'd like you to address the comments I made in the pull request before r+'ing this patch. Please, request review at me again once you address all of them.

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8551366 [details] [review]
proposed patch

LGTM, r=me with comments addressed. Please address them and land at will. Thanks Oscar!

Comment 9

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Landed: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/5fd94e5bde862f358b32a932a147e51ce30a8858