1121341 - [Loop] mozPaintedFrames, and video width height information for Rooms

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Oscar Patiño González]

Video width and height, and mozPaintedFrames information is not given for Room's calls.

Comment 1

[Oscar Patiño González]

Attachment: proposed patch

Comment 2

[Oscar Patiño González]

This patch is only visible if perfDebug is true. Update application with grunt buildDevelopment option to see fps, videowidth and videoheight values.

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8553010 [details] [review]
proposed patch

Left a few comments on the pull request. Please, have a look and request review at me again once you address them. Thanks Oscar!

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8553010 [details] [review]
proposed patch

Left a few comments on the pull request. Please, have a look and request review at me again once you address them. Thanks Oscar!

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8553010 [details] [review]
proposed patch

Almost there. Left a few comments on the pull request. Please, have a look and request review at me again once you address them. Thanks Oscar!

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8553010 [details] [review]
proposed patch

LGTM. r=me with nits addressed.

Thanks Oscar, address the comments I left in github and land at will.

Comment 7

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Landed: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/bc1cf4ac8112671a6d25b979c0c6f04e985948c8