1121347 - Expose isCdma to RadioInterface

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: RIL, defect)

Description

[Szu-Yu Chen [:aknow] (inactive)]

I think the information is required for TelephonyService.  Some of the operations there depend on the underlying technology.  By exposing isCdma to RadioInterface, we could make the things easier.  TelephonyService could check the value of isCdma through a synchronized function call.

gRadioInterfaceLayer.getRadioInterface(id).rilContext.isCdma

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 1: Remove unused code

Comment 2

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 2: Expose isCdma to RadioInterface (idl)

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 3: Expose isCdma to RadioInterface (ril)

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Szu-Yu Chen [:aknow] from comment #0)
> I think the information is required for TelephonyService.  Some of the
> operations there depend on the underlying technology.  By exposing isCdma to
> RadioInterface, we could make the things easier.  TelephonyService could
> check the value of isCdma through a synchronized function call.
> 
> gRadioInterfaceLayer.getRadioInterface(id).rilContext.isCdma

I believe we can get this information from mobileConnectionService/mobileConnectionInfo. 

Also, we are going to deprecate radioInterface.rilContext in bug 864489.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8548676 [details] [diff] [review]
Part 1: Remove unused code

Review of attachment 8548676 [details] [diff] [review]:
-----------------------------------------------------------------

This part is fine.

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8548677 [details] [diff] [review]
Part 2: Expose isCdma to RadioInterface (idl)

Review of attachment 8548677 [details] [diff] [review]:
-----------------------------------------------------------------

As my comment 4, we should take advantage of mobileConnectionService.voice.type to acquire cdma info. We don't need this change.

Comment 7

[Szu-Yu Chen [:aknow] (inactive)]

Set to WONTFIX based on Comment 6.