1121350 - `text-align: justify;` with `inline-block` causes extra space on right from whitespace

Status: VERIFIED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[madlittlemods]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.95 Safari/537.36

Steps to reproduce:

Demo: http://jsfiddle.net/ufy3f5tt/


Actual results:

There is an extra space on the right that messes with `text-align: justify;`.


Expected results:

The space shouldn't be there and the two elements should be on opposite sides(justified) of the wrapper.

The problem occurs with multiple elements as well.

You can get the proper layout by removing the whitespace at the end of the wrapper and the last element: http://jsfiddle.net/ufy3f5tt/2/

Comment 1

[madlittlemods]

I forgot to add that I can only reproduce this bug in Firefox developer Edition 36.0a2.

Comment 2

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
web layout regression that looks like it will be hitting the new betas (haven't checked yet) this week

Comment 3

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #2)
> [Tracking Requested - why for this release]:
> web layout regression that looks like it will be hitting the new betas
> (haven't checked yet) this week

Still broken on 36 beta 1.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: reporter's testcase, with jsFiddle gunk removed

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

On trunk (on Linux) I don't see the difference between the two cases.  Is it something already fixed on trunk?  In any case, regressionwindow-wanted stands.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Er, Gijs already marked it as such.

Comment 7

[Alice0775 White]

Regression pushlog: 
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6592c05a4bb2&tochange=8fd4e3a06f17

Regressed by: Bug 1063857

Fixed pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=36ff8406cca7&tochange=c1cba30ef56f

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

The first part and the third part of patch for bug 1116635 fix this problem.

Comment 9

[Xidorn Quan [:xidorn] UTC+10]

Let me fetch the beta repo and work on this.

Comment 10

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch backported from bug 1116635

What should I do now? This patch has previously been reviewed by roc, and should probably be good. Should I directly request for uplift to mozilla-beta?

Also, this patch will definitely cause conflict when beta is merged to later branches. Do we need to leave any special note somewhere for people about this?

Comment 11

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8549442 [details] [diff] [review]
patch backported from bug 1116635

It was reviewed, but since there was some refactor before the reviewed patch in this part, I guess it is probably better to be reviewed again.

Comment 12

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8549442 [details] [diff] [review]
patch backported from bug 1116635

Approval Request Comment
[Feature/regressing bug #]: bug 1063857, fixed in bug 1116635
[User impact if declined]: may see unwanted space at the end of some lines when justified
[Describe test coverage new/current, TBPL]: there is a test in bug 1116635, but no test is backported because that test relies on css ruby which may not work properly in the current beta
[Risks and why]: not sure, but I don't see risks with fixing this
[String/UUID change made/needed]: n/a

Comment 13

[Sylvestre Ledru [:Sylvestre]]

checkin-needed is not necessary. sheriff are scanning for approval-mozilla-beta+ ;)

Comment 14

[Xidorn Quan [:xidorn] UTC+10]

Gotcha :)

Comment 15

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/releases/mozilla-beta/rev/598cd9c2e480

Comment 16

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0
Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Firefox/36.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:36.0) Gecko/20100101 Firefox/36.0

Reproduced the issue on Firefox 36 beta 1, build ID: 20150114125146.

Confirming the fix on Firefox 36 beta 2, build ID: 20150120155007.