[System2][Screen cleanup] Make roamingWarningDialog become SystemDialog

RESOLVED WONTFIX

Status

Firefox OS
Gaia::System
RESOLVED WONTFIX
4 years ago
4 months ago

People

(Reporter: alive, Assigned: alive)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The roaming warning dialog inside quickSettings should become system dialog and loaded by mobileConnectionCore or a manager under mobileConnectionCore
Summary: [meta][System2] Save #screen element from class disaster → [System2][Screen cleanup] Make roamingWarningDialog become SystemDialog
Assignee: nobody → alive
Created attachment 8550147 [details] [review]
[PullReq] alivedise:bugzilla/1121356/roaming-warning-dialog to mozilla-b2g:master
Comment on attachment 8550147 [details] [review]
[PullReq] alivedise:bugzilla/1121356/roaming-warning-dialog to mozilla-b2g:master

Either of you review this? It's to move the roamingWarningDialog stuff out of quickSettings and add some tests(I am a little surprised there is no test :/)

Also this is currently broken in master because you could only see 'Not now' button but not the 'Turn on' button :(
Attachment #8550147 - Flags: review?(mhenretty)
Attachment #8550147 - Flags: review?(kgrandon)
Patch updated: I remove the softwareHomeQuickSettingsDialog because there is no proper way to invoke the dialog in integration test AND what's more important, the dialog now is a system dialog under #dialog-overlay so the test for modal_dialog should cover it.
Comment on attachment 8550147 [details] [review]
[PullReq] alivedise:bugzilla/1121356/roaming-warning-dialog to mozilla-b2g:master

Mike - you know the sim stuff better than I do, so could you review this? Thanks!
Attachment #8550147 - Flags: review?(kgrandon)
Comment on attachment 8550147 [details] [review]
[PullReq] alivedise:bugzilla/1121356/roaming-warning-dialog to mozilla-b2g:master

Ahhh, sorry about the late review!!

\o/ tests!

Ok, I left some comments on github. The biggest thing is that we need to make sure we use the `ril.data.roaming_enabled.warningDialog.enabled` setting before displaying the warning dialog.
Attachment #8550147 - Flags: review?(mhenretty)

Comment 6

4 months ago
Firefox OS is not being worked on
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.