1121356 - [System2][Screen cleanup] Make roamingWarningDialog become SystemDialog

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

The roaming warning dialog inside quickSettings should become system dialog and loaded by mobileConnectionCore or a manager under mobileConnectionCore

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] alivedise:bugzilla/1121356/roaming-warning-dialog to mozilla-b2g:master

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8550147 [details] [review]
[PullReq] alivedise:bugzilla/1121356/roaming-warning-dialog to mozilla-b2g:master

Either of you review this? It's to move the roamingWarningDialog stuff out of quickSettings and add some tests(I am a little surprised there is no test :/)

Also this is currently broken in master because you could only see 'Not now' button but not the 'Turn on' button :(

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Patch updated: I remove the softwareHomeQuickSettingsDialog because there is no proper way to invoke the dialog in integration test AND what's more important, the dialog now is a system dialog under #dialog-overlay so the test for modal_dialog should cover it.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8550147 [details] [review]
[PullReq] alivedise:bugzilla/1121356/roaming-warning-dialog to mozilla-b2g:master

Mike - you know the sim stuff better than I do, so could you review this? Thanks!

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8550147 [details] [review]
[PullReq] alivedise:bugzilla/1121356/roaming-warning-dialog to mozilla-b2g:master

Ahhh, sorry about the late review!!

\o/ tests!

Ok, I left some comments on github. The biggest thing is that we need to make sure we use the `ril.data.roaming_enabled.warningDialog.enabled` setting before displaying the warning dialog.

Comment 6

[BMO Automation]

Firefox OS is not being worked on