1121392 - Add bluetooth daemon to lollipop manifest

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Add bluetooth daemon to lollipop manifest

Comment 1

[howie [:howie]]

This build config to fetch daemon code is required for 2.2.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

FYI: The blueprint for this patch is in bug 1104620. Bluetoothd depends on libfdio.

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1121392 - Add bluetooth daemon to lollipop manifest

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8548819 [details] [review]
Bug 1121392 - Add bluetooth daemon to lollipop manifest

Should work, but maybe sorting alphabetically by the project name increases the readability of the file. Does the change get ported to v2.2 by Sheriffs?

Bruce, did you need any other repository for building on L? Such as 'system/bluetooth'?

Also, asking :mwu for an official review.

Comment 5

[Bruce Sun [:brsun]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #4)
> Comment on attachment 8548819 [details] [review]
> Bug 1121392 - Add bluetooth daemon to lollipop manifest
> 
> Bruce, did you need any other repository for building on L? Such as
> 'system/bluetooth'?

No. I can build 'system/libfdio', 'system/bluetoothd', and Gecko on L without 'system/bluetooth'.

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #4)
> Comment on attachment 8548819 [details] [review]
> Bug 1121392 - Add bluetooth daemon to lollipop manifest
> 
> Should work, but maybe sorting alphabetically by the project name increases
> the readability of the file.
Sure, I will change the order.
> Does the change get ported to v2.2 by Sheriffs?
It should get ported to v2.2 by sheriffs.
I guess it can be directly in v2.2, like https://bugzilla.mozilla.org/show_bug.cgi?id=1106858#c27 

For system/bluetooth, Lollipop codebase already removed this git repository.

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

The patch is similar with base-kk.xml, it seems mwu is busy, I redirect review to Kai-Zhen for this simple manifest patch (2.2 feature set).

Comment 8

[Kai-Zhen Li [:seinlin][:kli]]

Shawn, I think the repo name is not correct and I left message on PR. Can you update PR with correct repo name?

Comment 9

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Kai-Zhen Li [:seinlin] from comment #8)
> Shawn, I think the repo name is not correct and I left message on PR. Can
> you update PR with correct repo name?

I updated the patch during sorting alphabetically, I was wrong.
I've already update the patch again, thanks.

Comment 10

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8548819 [details] [review]
Bug 1121392 - Add bluetooth daemon to lollipop manifest

Looks good to me.

Comment 11

[Kai-Zhen Li [:seinlin][:kli]]

https://github.com/mozilla-b2g/b2g-manifest/commit/2f921fea805479a4ffdca44e1ab031a69c6cdcc5

This is a 2.2+ bug, Could you also send a PR to v2.2 branch?

Comment 12

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1121392 - Add bluetooth daemon to lollipop manifest (v2.2 for Nexus5)

Only nexus-5-l.xml is available but no base-l.xml in b2g-manifest v2.2 branch. So for v2.2, nexus-5-l.xml will be changed.

Comment 13

[Kai-Zhen Li [:seinlin][:kli]]

v2.2: https://github.com/mozilla-b2g/b2g-manifest/commit/2cba137f9bb7ddcce567e876ad9f04c447bbe51e