Closed Bug 1121406 Opened 10 years ago Closed 9 years ago

Enable WebSocket-in-Workers by default in release builds

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla38
Tracking Flags:
Tracking Status
firefox36 --- wontfix
firefox37 --- wontfix
firefox38 --- fixed
b2g-v2.2 --- wontfix
b2g-master --- fixed

People

(Reporter: baku, Assigned: baku)

Details

(Whiteboard: [games:p1][platform-rel-Games])

Attachments

(1 file)

ws.patch
1014 bytes, patch
smaug
: review+
lmandel
: approval-mozilla-aurora+
abillings
: approval-mozilla-beta+
Details | Diff | Splinter Review
Attached patch ws.patch — — Splinter Review 
We can land this patch in m-c and in aurora once bug 1111971 is landed too.
Attachment #8548817 - Flags: review?(bugs)
Summary: Enable WebSocket by default in aurora → Enable WebSocket by default in release builds
Attachment #8548817 - Flags: review?(bugs) → review+
Summary: Enable WebSocket by default in release builds → Enable WebSocket-in-Workers by default in release builds
Comment on attachment 8548817 [details] [diff] [review]
ws.patch

Approval Request Comment
[Feature/regressing bug #]: bug 504553
[User impact if declined]: no Websocket in workers by default
[Describe test coverage new/current, TBPL]: many mochitests
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8548817 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/d9cb791e29b8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment on attachment 8548817 [details] [diff] [review]
ws.patch

Aurora+
Attachment #8548817 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8548817 [details] [diff] [review]
ws.patch

Requesting backout for this patch.

Approval Request Comment
[Feature/regressing bug #]: 
[Risks and why]: The feature has currently one issue to solve
[String/UUID change made/needed]: NA

lmandel, unless the other issue is resolved, we need to back this out.
So, if that doesn't get a review+ in the next couple of hours, a+ here would let me to push the backout and reopen this bug.
Attachment #8548817 - Flags: approval-mozilla-beta?
Can't land bug 1140804 to beta. Need to back out this.
Attachment #8548817 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
baku, please figure out if we can fix the remaining issue on Aurora. Or otherwise we should land the backout also elsewhere.
Flags: needinfo?(amarchesini)
Smaug, we have the approval to land all the remaining fixes to Aurora, right?
We don't have to backout this patch in current aurora too.
Flags: needinfo?(bugs)
This landed to beta only, yes. So if everything is fixed in Aurora, that should be enough.
(better to mark this bug fixed then too)
Flags: needinfo?(bugs)
s/This landed/The backout landed/
I think we should mark this bug as fixed. In case we can reopen it but so far the patch is landed.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 9 years ago
Flags: needinfo?(amarchesini)
Resolution: --- → FIXED
Whiteboard: [games:p1] → [games:p1][platform-rel-Games]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: