1121434 - Get rid of or simplify executionMode

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Lars T Hansen [:lth]]

The Parallel execution mode is already gone, but that removal probably opens up for further simplifications.  This is tied into VMFunction also.

Comment 1

[Shu-yu Guo [:shu]]

I think ExecutionMode is fine as is so long as we try to confine it to jit/.

Comment 2

[Jan de Mooij [:jandem]]

(In reply to Shu-yu Guo [:shu] from comment #1)
> I think ExecutionMode is fine as is so long as we try to confine it to jit/.

Yeah, some analyses use IonBuilder and have their own ExecutionModes atm. It seems like we could remove all uses outside the compiler though (and also from codegen and most optimization passes).

Comment 3

[Shu-yu Guo [:shu]]

Attachment: Rename ExecutionMode to AnalysisMode.

Comment 4

[Jan de Mooij [:jandem]]

Comment on attachment 8549295 [details] [diff] [review]
Rename ExecutionMode to AnalysisMode.

Review of attachment 8549295 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks.

::: js/src/jsinfer.h
@@ +1573,3 @@
>  
>    public:
> +    static const uint32_t INVALID_SWEEP_INDEX = (1 << 30) - 1;

This should be (1u << 31) - 1 (max value that fits in 31 bits). 1u to avoid sign bit trouble.

@@ +1579,4 @@
>          pendingInvalidation_(false), sweepIndex_(INVALID_SWEEP_INDEX)
>      {}
>  
> +    CompilerOutput(JSScript *script)

The constructor should be `explicit` now.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2367e3a9712a
https://hg.mozilla.org/mozilla-central/rev/5ef9ad357f81
https://hg.mozilla.org/mozilla-central/rev/c9e0d02a1dc6