Closed Bug 1121454 Opened 11 years ago Closed 11 years ago

[Loop] [Telemetry] Background mode

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: opatinobugzilla, Assigned: opatinobugzilla)

References

Details

Attachments

(1 file, 2 obsolete files)

proposed patch
61 bytes, text/x-github-pull-request
macajc
: review+
Details | Review
Report to Telemetry servers the number of times Loop is awaken from background mode
Assignee: nobody → opatinobugzilla
Blocks: 1107899
Attached file proposed patch (obsolete) —
Attachment #8548886 - Flags: review?(carmen.jimenezcabezas)
Comment on attachment 8548886 [details] [review] proposed patch Please note that the way comment 0 is written makes it look like we should count all the ways the app can come from background mode, not just the notification clicks. If we should only count the notification clicks, then please just rerequest the review.
Flags: needinfo?(opatinobugzilla)
Attachment #8548886 - Flags: review?(carmen.jimenezcabezas)
Finally, the event that is counted is: going to background and going back to the room again
Flags: needinfo?(opatinobugzilla)
Depends on: 1113602
Attachment #8548886 - Flags: review?(carmen.jimenezcabezas)
Returning from background mode is counted whenever getting back to application, either from icon on homescreen or via notification screen
Attachment #8548886 - Flags: review?(carmen.jimenezcabezas)
Attachment #8548886 - Attachment is obsolete: true
Attached file proposed patch (obsolete) —
Attachment #8551173 - Attachment is obsolete: true
Attachment #8551173 - Flags: review?(carmen.jimenezcabezas)
Attached file proposed patch —
Attachment #8551201 - Flags: review?(carmen.jimenezcabezas)
Attachment #8551173 - Flags: review?(carmen.jimenezcabezas)
Comment on attachment 8551201 [details] [review] proposed patch I left some comments in git, please take a look and rerequest again, thanks
Attachment #8551201 - Flags: review?(carmen.jimenezcabezas)
Attachment #8551201 - Flags: review?(carmen.jimenezcabezas)
Comment on attachment 8551201 [details] [review] proposed patch LGTM, thanks a lot Oscar
Attachment #8551201 - Flags: review?(carmen.jimenezcabezas) → review+
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/a0d73114523789e7479066ade2e5ccc56198f361
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: