1121466 - Use web app manifest short_name below icons on homescreen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Chris Lord [:cwiiis]]

The homescreen specification available in bug 1067435 has recently been updated and shows that we should be using short_name underneath icons, when it's available.

Comment 1

[Ben Francis [:benfrancis]]

Hi Chris, are you able to take this?

Comment 2

[Chris Lord [:cwiiis]]

Whoops, I meant to take this a while ago - Ben, if you want to work on it, feel free to take it back - I'm assuming that assigning it to you was a mistake(?)

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1121466-homescreen-short-name > mozilla-b2g:master

Comment 4

[Chris Lord [:cwiiis]]

Comment on attachment 8563501 [details] [review]
[gaia] Cwiiis:bug1121466-homescreen-short-name > mozilla-b2g:master

Support short_name in manifest + marionette test

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8563501 [details] [review]
[gaia] Cwiiis:bug1121466-homescreen-short-name > mozilla-b2g:master

Left a nit on github, but I think this is generally fine. Tree is currently closed, so maybe try to close/re-open the PR once gaia is open to get a try run. Thanks!

Comment 6

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/eb2cc08cc343997d327ee065e45e05d43d250182

Comment 7

[Chris Lord [:cwiiis]]

Comment on attachment 8563501 [details] [review]
[gaia] Cwiiis:bug1121466-homescreen-short-name > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Apps with long names that have shorter names specified in their manifest will display the long name on the homescreen, possibly resulting in a confusing/bad-looking app icon subtitle.
[Testing completed]: Manually and marionette test
[Risk to taking this patch] (and alternatives if risky): Low risk, small change with automated testing
[String changes made]: None

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/d386821cd2371075d168fac69b871db0d88cf76e

Comment 9

[Hermes Cheng (inactive after July 27, 2015)]

Verified with below builds:

*2.2
Build ID               20150329162502
Gaia Revision          473cd63f53c855299b719285d9b95e3f2910782f
Gaia Date              2015-03-27 20:14:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4b13c4254e2f
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150329.200030
Firmware Date          Sun Mar 29 20:00:41 EDT 2015
Bootloader             L1TC000118D0

*master
Build ID               20150329160203
Gaia Revision          67ad91f3f660b1f16b354ee4c5159ddc5a74d149
Gaia Date              2015-03-28 10:02:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/385840329d91
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150329.191719
Firmware Date          Sun Mar 29 19:17:28 EDT 2015
Bootloader             L1TC100118D0