1121473 - Why do we have duplicated "is void" lists of HTML tag names?

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Specifically the older nsContentUtils::IsHTMLVoid and the newer IsVoidTag() in FragmentOrElement.  Looks like the latter was added in bug 744830.  Henri, Olli, why didn't we just use the existing implementation, or update it if that was desired?

Comment 1

[Henri Sivonen (:hsivonen)]

(In reply to Boris Zbarsky [:bz] from comment #0)
> Specifically the older nsContentUtils::IsHTMLVoid and the newer IsVoidTag()
> in FragmentOrElement.  Looks like the latter was added in bug 744830. 
> Henri, Olli, why didn't we just use the existing implementation, or update
> it if that was desired?

I don't recall/know. FragmentOrElement needs a high-performance implementation, which may have caused a bias towards writing something specifically for that case. I'm not sure if at the time of bug 744830 either of us realized that nsContentUtils had a method for this.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

IIRC I didn't want to change the behavior of plaintextserializer, but just make
innerHTML to follow the spec better. So, to decrease the risk for regressions.

Comment 3

[Boris Zbarsky [:bzbarsky]]

OK, but the two lists are identical, right?  So there should be no behavior change I can see...

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Oh, so they are. Somehow managed to look that wrong earlier today. Then my memory was wrong.
I do recall the version in FragmentOrElement was all about micro-optimizing.

But ok, need to merge those too.

Comment 5

[Boris Zbarsky [:bzbarsky]]

I guess IsVoidTag is inline, and keeping that will be a bit of a pain...

Also, I think we can nix nsPlainTextSerializer::GetIdForContent while we're here.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=69ceabba6b5c

This should be pretty much the minimal possible patch while keeping the
stuff inlined, I think

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: +missing null check

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b178fc355421

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b178fc355421