Closed Bug 1121476 Opened 10 years ago Closed 10 years ago

[Loop] [Telemetry] Reporting: # times a room is visited&used

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: opatinobugzilla, Assigned: opatinobugzilla)

References

Details

Attachments

(1 file, 1 obsolete file)

proposed patch
61 bytes, text/x-github-pull-request
macajc
: review+
Details | Review
Report to Telemetry servers the number of times a room is visited and how many successful connections proceeded.
Assignee: nobody → opatinobugzilla
Attached file proposed patch (obsolete) —
Attachment #8548900 - Flags: review?(carmen.jimenezcabezas)
Blocks: 1098581
Comment on attachment 8548900 [details] [review] proposed patch I think you have merged two bug (current one and 1113602) In any case please follow the guide lines of the review in bug 1113602
Attachment #8548900 - Flags: review?(carmen.jimenezcabezas) → review-
Depends on: 1113602
Attached file proposed patch —
Attachment #8548900 - Attachment is obsolete: true
Attachment #8552324 - Flags: review?(carmen.jimenezcabezas)
Comment on attachment 8552324 [details] [review] proposed patch I left some comments on git, please take a look and rerequest again, thanks
Attachment #8552324 - Flags: review?(carmen.jimenezcabezas)
Attachment #8552324 - Flags: review?(carmen.jimenezcabezas)
Attachment #8552324 - Flags: review?(carmen.jimenezcabezas)
Attachment #8552324 - Flags: review?(carmen.jimenezcabezas)
Attachment #8552324 - Flags: review?(carmen.jimenezcabezas)
Attachment #8552324 - Flags: review?(carmen.jimenezcabezas)
Comment on attachment 8552324 [details] [review] proposed patch LGTM. Thanks for your work here!
Attachment #8552324 - Flags: review?(carmen.jimenezcabezas) → review+
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/033da7d4aba4b4c5a1ac8dfdc9120c4887e9360f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: