1121647 - Screen turns off by timeout while playing flash video

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Plugins, defect)

Description

[Ilya Gordeev]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20150114183400

Steps to reproduce:

Play flash video. Version: Flash Player 11.1 for Android 4.0 (11.1.115.81)


Actual results:

Screen turns off by timeout.


Expected results:

Screen shouldn't turn off while playing flash video. Previous version Firefox 34 for Android worked fine.

Comment 1

[Aaron Train [:aaronmt]]

Sounds like lifecycle issues with the plugin.

Comment 2

[Teodora Vermesan (:TeoVermesan)]

On Alcatel One Touch (Android 4.1.2) from Settings -> Display -> I set "Sleep after 15 sec of inactivity" and then play www.intel.com/museumofme/mobile/index.htm. flash video.
Screen turns off while playing the flash video on Firefox for Android 35, Firefox for Android 36 Beta 1, latest Aurora 37.0a2 and latest Nightly 38.0a1. 
The video played until the end on Firefox 34.0.1

Comment 3

[Aaron Train [:aaronmt]]

Can you assist with a regression-range?

Comment 4

[Teodora Vermesan (:TeoVermesan)]

Regression window-wanted:

good build: 03-10-2014 
bad build: 04-10-2014  
pushlog:http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b85c260821ab&tochange=229801d17f7e

Bug 1022669 - Display does not turn off while playing audio
Note: scenarios tested
flash video: http://goo.gl/VLqwCA
audio file: http://goo.gl/lv8SLA
HTML5 video:  http://goo.gl/gStfPS
From Settings -> Display -> I set "Sleep after 15 sec of inactivity" and leave the video play for a while:

03-10-2014 build:
1. flash video => The screen won't go off while playing a flash video.
2. audio file => The screen won't go off while audio file is played.
3. HTML5 video => The screen won't go off while playing a HTML5 video.

04-10-2014 build:
1. flash video => The screen turns off while no audio is heard.
2. audio file => The screen turns off while audio is heard.
3. HTML5 video => The screen won't go off while playing a HTML5 video.

So, the screen shouldn't go off by timeout while playing a flash and a HTML5 video and it should go off by timeout while playing an audio file.

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

Looks like this is expected behavior after bug 1022669 what is going to be our behavior here?

Comment 6

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I understand that we should be able to continue playing audio even with the screen off but video should leave it on... unless I'm missing something? (totally possible)

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

bug 1022669 changed this behavior for Fx35 we need to make a decision if we should prioritize battery life or uninterrupted video?

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Bug 1022669 changed the behavior for HTML video and HTML audio, but did nothing for Flash video.

I believe the issue is how do we get Flash video to act like HTML video? Where in the plugin code do we add the wakelock call to keep the screen from turning off while Flash is playing a video?

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

We're supposed to respond to Flash's wakelock requests in ANPSystem.cpp:setPowerState(). Maybe something has gone wrong there.

Comment 10

[Jose moya]

Same problem here when we flash videos online the screen turn off as if we are not watch nothing. Please you help.me?

Comment 11

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Use correct wake lock topic for Flash on Android

This ensures we are using the right topic string in order to keep the screen on.

Comment 12

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dcffe1f134a7

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dcffe1f134a7

Comment 14

[Teodora Vermesan (:TeoVermesan)]

Going to Settings -> Display -> I set "Sleep after 15 sec of inactivity" and then played www.intel.com/museumofme/mobile/index.htm video. The screen does not go off while playing it, so:
Verified as fixed using:
Build: Firefox for Android 38.0a1 (2015-02-04)
Device: Alcatel One Touch (Android 4.1.2)