Closed
Bug 1121661
Opened 9 years ago
Closed 9 years ago
Firefox crash in mp4_demuxer::MP4Demuxer::SeekVideo(__int64)
Categories
(Core :: Audio/Video, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla38
People
(Reporter: marcia, Assigned: mattwoodrow)
References
(Blocks 1 open bug)
Details
(Keywords: crash)
Crash Data
Attachments
(1 file)
1014 bytes,
patch
|
bholley
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-a18bb9d8-a450-418d-b627-f32662150113. ============================================================= Seen while looking at nightly crash stats. This low volume crash occurs on Win 7, 8 and 10. Link to most recent crashes: https://crash-stats.mozilla.com/report/list?productFirefox&signature=mp4_demuxer::MP4Demuxer::SeekVideo%28__int64%29. Majority of URLs are all youtube.com Frame Module Signature Source 0 xul.dll mp4_demuxer::MP4Demuxer::SeekVideo(__int64) media/libstagefright/binding/mp4_demuxer.cpp 1 xul.dll mozilla::MP4Reader::ResetDecode() dom/media/fmp4/MP4Reader.cpp 2 xul.dll nsRunnableMethodImpl<tag_nsresult ( mozilla::net::CacheFileContextEvictor::*)(void), void, 1>::Run() xpcom/glue/nsThreadUtils.h 3 xul.dll mozilla::MediaTaskQueue::Runner::Run() dom/media/MediaTaskQueue.cpp 4 xul.dll nsThreadPool::Run() xpcom/threads/nsThreadPool.cpp 5 xul.dll nsThread::ProcessNextEvent(bool, bool*) xpcom/threads/nsThread.cpp 6 xul.dll NS_ProcessNextEvent(nsIThread*, bool) xpcom/glue/nsThreadUtils.cpp 7 xul.dll mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) ipc/glue/MessagePump.cpp 8 xul.dll MessageLoop::RunHandler() ipc/chromium/src/base/message_loop.cc 9 xul.dll MessageLoop::Run() ipc/chromium/src/base/message_loop.cc 10 xul.dll nsThread::ThreadFunc(void*) xpcom/threads/nsThread.cpp 11 nss3.dll PR_NativeRunThread nsprpub/pr/src/threads/combined/pruthr.c 12 nss3.dll pr_root nsprpub/pr/src/md/windows/w95thred.c 13 msvcr120.dll _callthreadstartex f:\dd\vctools\crt\crtw32\startup\threadex.c:376 14 msvcr120.dll _threadstartex f:\dd\vctools\crt\crtw32\startup\threadex.c:354 15 kernel32.dll BaseThreadInitThunk 16 ntdll.dll RtlUserThreadStart 17 kernel32.dll BasepReportFault 18 kernel32.dll BasepReportFault
Assignee | ||
Comment 1•9 years ago
|
||
mDemuxer must be nullptr for this to happen. Looks like this could be the case if we get a call to ResetDecode before we've run ReadMetadata and created the demuxer.
Assignee: nobody → matt.woodrow
Attachment #8549151 -
Flags: review?(ajones)
Updated•9 years ago
|
Priority: -- → P1
Comment 2•9 years ago
|
||
Comment on attachment 8549151 [details] [diff] [review] Null check mDemuxer Review of attachment 8549151 [details] [diff] [review]: ----------------------------------------------------------------- Yep, my patch in bug 1119456 made us lazily initialize mDemuxer.
Attachment #8549151 -
Flags: review?(ajones) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/674ba4e9ed25
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/674ba4e9ed25
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment 5•9 years ago
|
||
Comment on attachment 8549151 [details] [diff] [review] Null check mDemuxer Approval Request Comment [Feature/regressing bug #]: MSE [User impact if declined]: Crashes playing video. [Describe test coverage new/current, TBPL]: Laned on m-c. [Risks and why]: Low. Straightforward null check unlikely to have side-effects. [String/UUID change made/needed]: None.
Attachment #8549151 -
Flags: approval-mozilla-beta?
Attachment #8549151 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8549151 -
Flags: approval-mozilla-beta?
Attachment #8549151 -
Flags: approval-mozilla-beta+
Attachment #8549151 -
Flags: approval-mozilla-aurora?
Attachment #8549151 -
Flags: approval-mozilla-aurora+
Reporter | ||
Comment 6•9 years ago
|
||
It appears there were some Mac crashes as well in this signature - https://crash-stats.mozilla.com/report/list?productFirefox&signature=mp4_demuxer::MP4Demuxer::SeekVideo%28long%20long%29 Adding that signature to the crash field.
Crash Signature: [@ mp4_demuxer::MP4Demuxer::SeekVideo(__int64)] → [@ mp4_demuxer::MP4Demuxer::SeekVideo(__int64)]
[@ mp4_demuxer::MP4Demuxer::SeekVideo(long long)]
Comment 7•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/e2ca4b9c3d70 https://hg.mozilla.org/releases/mozilla-beta/rev/28900712c87f
Comment 8•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/e2ca4b9c3d70
status-b2g-v2.2:
--- → fixed
status-b2g-master:
--- → fixed
Updated•9 years ago
|
Flags: qe-verify+
Comment 9•9 years ago
|
||
No crash reports in Socorro after 2015-01-15 builds. Marking as verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•