Closed Bug 1121666 Opened 10 years ago Closed 10 years ago

./mach marionette-test --jsdebugger doesn't work with e10s

Categories

(Remote Protocol :: Marionette, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(e10s+)

RESOLVED FIXED
mozilla38
Tracking Status
e10s + ---

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

(Keywords: pi-marionette-runner)

Attachments

(1 file, 1 obsolete file)

The notification box just goes away. The prompt service works about as well, let's just use that.
/r/2497 - Bug 1121666 - Use the promptservice instead of a notification box to block tests from starting right away when using marionette with --jsdebugger.;r=ato

Pull down this commit:

hg pull review -r a31d8d35103f19e05308c32d9b4e6f2a97563a4e
tracking-e10s: --- → +
Comment on attachment 8549137 [details]
MozReview Request: bz://1121666/chmanchester

I just realized this might not play well with the catch-all modal dialog handler I'm proposing to add in bug 906712
Attachment #8549137 - Flags: review?(ato)
I tested and this disagrees with the patch in bug 906712, but given that patch is in flux and this fix provides immediate value, I'm just going to land this.
Or, I would have, if inbound had been open.
https://hg.mozilla.org/mozilla-central/rev/6453aaba884f
Assignee: nobody → cmanchester
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Attachment #8549137 - Attachment is obsolete: true
Attachment #8619131 - Flags: review+
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: