1121666 - ./mach marionette-test --jsdebugger doesn't work with e10s

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

The notification box just goes away. The prompt service works about as well, let's just use that.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: bz://1121666/chmanchester

Comment 2

[Chris Manchester (limited bugmail, email directly)]

/r/2497 - Bug 1121666 - Use the promptservice instead of a notification box to block tests from starting right away when using marionette with --jsdebugger.;r=ato

Pull down this commit:

hg pull review -r a31d8d35103f19e05308c32d9b4e6f2a97563a4e

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8549137 [details]
MozReview Request: bz://1121666/chmanchester

I just realized this might not play well with the catch-all modal dialog handler I'm proposing to add in bug 906712

Comment 4

[David Burns :automatedtester]

https://reviewboard.mozilla.org/r/2495/#review1719

Ship It!

Comment 5

[Chris Manchester (limited bugmail, email directly)]

I tested and this disagrees with the patch in bug 906712, but given that patch is in flux and this fix provides immediate value, I'm just going to land this.

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Or, I would have, if inbound had been open.

Comment 7

[Chris Manchester (limited bugmail, email directly)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6453aaba884f

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6453aaba884f

Comment 10

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1121666 - Use the promptservice instead of a notification box to block tests from starting right away when using marionette with --jsdebugger.;r=ato