1121792 - [selectors4] support wildcard (*) argument to :lang() selector and add support for string arguments

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Selectors level 4 adds support for wildcards (*) in the :lang() selector, with reference to RFC4647 language matching.

We should probably implement this, and **at the same time** add support for string arguments to :lang().

http://dev.w3.org/csswg/selectors/#the-lang-pseudo
https://lists.w3.org/Archives/Public/www-style/2015Jan/0269.html (minutes of meeting, not yet reflected in draft, where WG agreed that argument should either be ident or quoted string)

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1121792 - Use more complete BCP47/RFC4647 language-range matching rather than simple prefix-dash match for the :lang() pseudo. r=#layout-reviewers

This is a Selectors-4 enhancement to the spec for the :lang() pseudo-class.
It seems Safari has been shipping this behavior for some time.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1121792 - Accept a comma-separated list of language codes in the :lang() pseudo. r=#layout-reviewers

This is the other extension to the :lang() pseudo-class in Selectors-4.
(Also supported in Safari.)

Depends on D174999

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1121792 - Add WPT tests for enhanced :lang() pseudo in css-selectors-4. r=#layout-reviewers

Depends on D175000

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1121792 - Split document-metadata/the-meta-element/http-equiv-and-name.html into separate tests for color-scheme and lang, using a valid value for each. r=emilio

Depends on D175001

Comment 5

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1121792 - Update selectors/i18n/css3-selectors-lang-014.html because in Selectors 4, :lang() tag matching uses RFC4647 filtering rather than just a prefix match. r=#layout-reviewers

Depends on D175002

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1121792 - Allow to use ThinVec/nsTArray in the style crate. r=jfkthame

This allows to clean-up the previous patches by using a single ThinVec
(which stores length / capacity along with the allocation).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e535870263d8
Use more complete BCP47/RFC4647 language-range matching rather than simple prefix-dash match for the :lang() pseudo. r=emilio
https://hg.mozilla.org/integration/autoland/rev/2e4e3ae6cddd
Accept a comma-separated list of language codes in the :lang() pseudo. r=emilio
https://hg.mozilla.org/integration/autoland/rev/be24fa5c3e70
Add WPT tests for enhanced :lang() pseudo in css-selectors-4. r=emilio
https://hg.mozilla.org/integration/autoland/rev/9726f4b6035a
Split document-metadata/the-meta-element/http-equiv-and-name.html into separate tests for color-scheme and lang, using a valid value for each. r=emilio
https://hg.mozilla.org/integration/autoland/rev/195d689a6b12
Update selectors/i18n/css3-selectors-lang-014.html because in Selectors 4, :lang() tag matching uses RFC4647 filtering rather than just a prefix match. r=emilio
https://hg.mozilla.org/integration/autoland/rev/879211a561cc
Allow to use ThinVec/nsTArray in the style crate. r=jfkthame,layout-reviewers

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39501 for changes under testing/web-platform/tests

Comment 9

[Narcis Beleuzu [:NarcisB]]

Backed out for mochitest failures in malloc_usable_size

Backout link: https://hg.mozilla.org/integration/autoland/rev/4939d1bb0b03717bf2602f319721c3f833e62916
Log link: https://treeherder.mozilla.org/logviewer?job_id=412222778&repo=autoland&lineNumber=2738

Comment 10

[Narcis Beleuzu [:NarcisB]]

Please also check this crashes "[@ style::gecko_string_cache::WeakAtom::as_slice]" and this xpcshell failures.

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b340f31925aa
Use more complete BCP47/RFC4647 language-range matching rather than simple prefix-dash match for the :lang() pseudo. r=emilio
https://hg.mozilla.org/integration/autoland/rev/95817aa93cfb
Accept a comma-separated list of language codes in the :lang() pseudo. r=emilio
https://hg.mozilla.org/integration/autoland/rev/bc74ba399e3a
Add WPT tests for enhanced :lang() pseudo in css-selectors-4. r=emilio
https://hg.mozilla.org/integration/autoland/rev/44278aa68c6a
Split document-metadata/the-meta-element/http-equiv-and-name.html into separate tests for color-scheme and lang, using a valid value for each. r=emilio
https://hg.mozilla.org/integration/autoland/rev/f1dcf4173070
Update selectors/i18n/css3-selectors-lang-014.html because in Selectors 4, :lang() tag matching uses RFC4647 filtering rather than just a prefix match. r=emilio

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95df5b6a464f
Allow to use ThinVec/nsTArray in the style crate. r=jfkthame,layout-reviewers

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b340f31925aa
https://hg.mozilla.org/mozilla-central/rev/95817aa93cfb
https://hg.mozilla.org/mozilla-central/rev/bc74ba399e3a
https://hg.mozilla.org/mozilla-central/rev/44278aa68c6a
https://hg.mozilla.org/mozilla-central/rev/f1dcf4173070
https://hg.mozilla.org/mozilla-central/rev/95df5b6a464f

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 16

[Brian Thomas Smith [bsmth]]

Documentation changes can be tracked in the following GitHub issue: https://github.com/mdn/content/issues/26688

Comment 17

[Michał Gołębiowski-Owczarek [:mgol]]

This might have caused bug 1839747, PTAL.