1121831 - [Privacy Panel] Transparency Control: apps search filter

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Fabien Cazenave [:kaze]]

Following bug 1118003, here’s the implementation of the “Apps search” filter that has been specified here:

https://drive.google.com/folderview?id=0B5rfAsa_Z3pBZUx1RXpUdmNmVFU&usp=sharing

Comment 1

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

https://github.com/mozilla-b2g/gaia/pull/27303/

Comment 2

[Etienne Segonzac (:etienne)]

Comment on attachment 8549390 [details] [review]
patch proposal

Comments on github (non trivial but we'll get there :))

Comment 3

[Fabien Cazenave [:kaze]]

Comment on attachment 8549390 [details] [review]
patch proposal

Thanks for the useful comments Étienne, here’s an updated version.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] fabi1cazenave:transparency-search > mozilla-b2g:master

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 8549390 [details] [review]
patch proposal

r=me with a green try but feel free to flag me again if the change required to fix the keyboard hiding issue is big/weird :)

Comment 6

[Fabien Cazenave [:kaze]]

I found the error in the integration tests, here’s a green try: https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=fc95223b009d

Merged on master: https://github.com/mozilla-b2g/gaia/commit/b420fc5

Comment 7

[Fabien Cazenave [:kaze]]

Comment on attachment 8549390 [details] [review]
patch proposal

[Approval Request Comment]
[User impact] if declined: applications can’t be filtered in the Privacy Panel
[Testing completed]: manual + integration
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: 3 new strings

Comment 8

[Etienne Segonzac (:etienne)]

I'm perfectly fine with the test change but the `leaveSearchMode` in `apps/privacy-panel/test/marionette/lib/panels/tc_main.js` is now dead code right? Might be worth it to file a tiny follow up to remove it.

Note: this is a test only follow up removing an unused method it should not block the approval request.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/22b8cd14267a8746109e43804d1e42775261181e

Comment 10

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly Flame 3.0 and 2.2 builds.

Actual Results: App searching is available in the Transparency Control panel.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150302010223
Gaia: f34ce82a840ad3c0aed3bfff18517b3f6a0eb37f
Gecko: eea6188b9b05
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150302002504
Gaia: 77609916ca5ab721150fab2b7bc5c37f43ee3a5a
Gecko: 27ab8aa34201
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0