Closed
Bug 1121853
Opened 11 years ago
Closed 11 years ago
Add [AvailableIn="CertifiedApps"] and [CheckPermissions="voicemail"] to Voicemail interfaces
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(firefox38 fixed)
RESOLVED
FIXED
2.2 S5 (6feb)
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | fixed |
People
(Reporter: hsinyi, Assigned: hsinyi)
References
Details
Attachments
(1 file, 1 obsolete file)
|
6.05 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
To hide the below from privileged or web content:
MozVoicemailEvent.webidl
MozVoicemailStatus.webidl
MozVoicemail.webidl
| Assignee | ||
Updated•11 years ago
|
Assignee: nobody → htsai
| Assignee | ||
Comment 1•11 years ago
|
||
1) Add [AvailableIn="CertifiedApps"] and [CheckPermissions="voicemail"]
2) Modify mochitests
| Assignee | ||
Comment 2•11 years ago
|
||
Remove trailing w.s.
Attachment #8559569 -
Attachment is obsolete: true
| Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 8559570 [details] [diff] [review]
patch (v2)
Review of attachment 8559570 [details] [diff] [review]:
-----------------------------------------------------------------
Hi Olli,
Another similar work :)
Voicemail API was designed for certified apps only. And I haven't heard of any plan to move it to privilege apps or web content yet. So this patch just adds webidl attributes to reflect the case properly.
Attachment #8559570 -
Flags: review?(bugs)
Comment 4•11 years ago
|
||
Comment on attachment 8559570 [details] [diff] [review]
patch (v2)
All this stuff is certified only, so should be fine.
(not a mix of privileged and certified)
Attachment #8559570 -
Flags: review?(bugs) → review+
| Assignee | ||
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox38:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S5 (6feb)
You need to log in
before you can comment on or make changes to this bug.
Description
•