1121909 - [Bluetooth] Implement send file flow, device list, and inline pairing in Bluetooth app for v2 API changed.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[[e-mail], [e-mail]]

STR:

0. Share a picture in Gallery app via Bluetooth.
1. Turn Bluetooth on if it is disabled.
2. Select a remote device for sending file with inline pairing.

or
2. Select a paired device for sending file.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] ian-liu:bluetooth/bug1121909_share_activity_via_bluetooth_for_BT_v2_api > mozilla-b2g:master

Comment 2

[[e-mail], [e-mail]]

Comment on attachment 8579811 [details] [review]
[gaia] ian-liu:bluetooth/bug1121909_share_activity_via_bluetooth_for_BT_v2_api > mozilla-b2g:master

Arthur, the patch is ready for Bluetooth app while platform switches to Bluetooth APIv2. And I do some manual tests, especially edge case, it's working fine for me as before. I would like your feedback for the architecture. If you feel good, let's go into review process with my updating unit test. Thanks.

BTW, the notification of file transfer is not running on Bluetooth APIv2 because bluetooth_core module does not start bluetooth_transfer module yet. I think all of the flow will be worked while system Bluetooth V2 is ready.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8579811 [details] [review]
[gaia] ian-liu:bluetooth/bug1121909_share_activity_via_bluetooth_for_BT_v2_api > mozilla-b2g:master

The patch is looking good, thanks!

Comment 4

[[e-mail], [e-mail]]

Comment on attachment 8579811 [details] [review]
[gaia] ian-liu:bluetooth/bug1121909_share_activity_via_bluetooth_for_BT_v2_api > mozilla-b2g:master

Arthur, I have updated the patch with unit tests. Besides of transfer_manager(I'm still writing for it.), other new created modules are ready for unit test. Could you please help to review my patch? Thanks.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8579811 [details] [review]
[gaia] ian-liu:bluetooth/bug1121909_share_activity_via_bluetooth_for_BT_v2_api > mozilla-b2g:master

There are some comments to be addressed before merging. Please check the details in github, thanks!

Comment 6

[[e-mail], [e-mail]]

Comment on attachment 8579811 [details] [review]
[gaia] ian-liu:bluetooth/bug1121909_share_activity_via_bluetooth_for_BT_v2_api > mozilla-b2g:master

Arthur, thanks for your reminder in this patch. I have updated it with your suggestion. And unit tests are done for covering all of these changed. Will need your review again.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8579811 [details] [review]
[gaia] ian-liu:bluetooth/bug1121909_share_activity_via_bluetooth_for_BT_v2_api > mozilla-b2g:master

Good job! Most of the comments are regarding the tests but should be easy to fix. The only comment on the code is that we may have to return the promise from `_onDevicePicked` and making sure the map function return a promise in async cases or `_endTransferWithReason` would be called immediately instead of after all blobs get sent.

Comment 8

[[e-mail], [e-mail]]

Thanks for Arthur's reviewing effort with such patience. I have updated the patch with all of your comments. And the test script is more simple in the test case '_onDevicePicked'.

Since the patch is landed, we can close the issue now.

Gaia/master:  https://github.com/mozilla-b2g/gaia/commit/edc3a889b20520f0a2b9a14b63dd6609f621069e