1121917 - [Contacts] Contact details wrong view when special characters are present

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Noemí Freire (:noemi)]

Attachment: Contact_Details_View

Description:
Contact details wrong view and unexpected vcard file name within Messaging app when special characters are present in the contact


STRs:
1- Create a contact including special characters (Name: Pruebá; Last Name: Eñe). Please see "Contact_Details-View.png" and "Contacts_List.png" files attached.
2- Go to Messaging app and try to share that contact via MMS. Once the .vcf file is attached, the name of that file ("Prueba_Ene") is not the expected one (Pruebá_Eñe). Please see "Message_Thread.png" file attached.
3- Being in the message thread, click on the contact vcard
4- Contact details screen is opened, the Name and the Last Name of the contact are not the expected ones, please see "Contact_Details_View_From_Messaging.png" file attached


Environmental Variables:
Device: flame-kk (Build Number 142)
BuildID: 20150115065156
Gecko: c815fdc
Gaia-9a85671
Version: 38.0a1


Repro frequency: 100%

Comment 1

[Noemí Freire (:noemi)]

Attachment: Contacts_List

Comment 2

[Noemí Freire (:noemi)]

Attachment: Message_Thread

Comment 3

[Noemí Freire (:noemi)]

Attachment: Contact_Details_View_From_Messaging

Comment 4

[Jose Manuel Cantera]

Attachment: PR to GH

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8549549 [details] [review]
PR to GH

Can we have test for the output generated in ContactToVcardBlob ?

Comment 6

[Johan Lorenzo [:jlorenzo]]

Triage: New feature broken which will impact all languages that use accented characters.

Comment 7

[Jose Manuel Cantera]

Comment on attachment 8549549 [details] [review]
PR to GH

comments addressed and tests added

thanks!

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8549549 [details] [review]
PR to GH

Perfect, thanks a lot for adding the test.

Not granting the approval since the unit test is failing in gaia-try.

Comment 9

[Jose Manuel Cantera]

Attachment: GH PR

Comment 10

[Jose Manuel Cantera]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #8)
> Comment on attachment 8549549 [details] [review]
> PR to GH
> 
> Perfect, thanks a lot for adding the test.
> 
> Not granting the approval since the unit test is failing in gaia-try.

It seems you checked a previous execution of gaia-try. I have changed the PR just to force a gaia-try relaunch but no luck till the moment. Once the ga-atry job finishes I will ping you on IRC

thanks

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8551175 [details] [review]
GH PR

Thanks Jose, please merge once we have gaia-try green.

Comment 12

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/00fd3b640acefdfd886a113408f0fdb5fde1b516

Comment 13

[Jose Manuel Cantera]

Comment on attachment 8551175 [details] [review]
GH PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): vcard attachments / sharing
[User impact] if declined: Very high, special characters in non-English languages can appear as corrupted and the vcards received by users will be useless. 
[Testing completed]: Yes, unit tests provided
[Risk to taking this patch] (and alternatives if risky): nearly-zero-risk patch
[String changes made]: none

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/011cc5f6713f2b44c8e7d3ad97ecc91cdcf83e64

Comment 15

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

On the latest Nightly Flame 3.0 and 2.2 builds, the contacts details view when adding through the messages app does not corrupt special characters.  However the filename as expected according to step 2 of the description is still incorrect.

Is this the expected results from your changes Jose?

Environmental Variables:
Device: Flame 3.0
BuildID: 20150302010223
Gaia: f34ce82a840ad3c0aed3bfff18517b3f6a0eb37f
Gecko: eea6188b9b05
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2
BuildID: 20150302002504
Gaia: 77609916ca5ab721150fab2b7bc5c37f43ee3a5a
Gecko: 27ab8aa34201
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 16

[Jose Manuel Cantera]

(In reply to Jayme Mercado [:JMercado] from comment #15)
> On the latest Nightly Flame 3.0 and 2.2 builds, the contacts details view
> when adding through the messages app does not corrupt special characters. 
> However the filename as expected according to step 2 of the description is
> still incorrect.
> 
> Is this the expected results from your changes Jose?

Yes, we did not fix anything related to the filename, only to the content. 

> 
> Environmental Variables:
> Device: Flame 3.0
> BuildID: 20150302010223
> Gaia: f34ce82a840ad3c0aed3bfff18517b3f6a0eb37f
> Gecko: eea6188b9b05
> Gonk: e7c90613521145db090dd24147afd5ceb5703190
> Version: 39.0a1 (3.0) 
> Firmware Version: v18D-1
> User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0
> 
> Environmental Variables:
> Device: Flame 2.2
> BuildID: 20150302002504
> Gaia: 77609916ca5ab721150fab2b7bc5c37f43ee3a5a
> Gecko: 27ab8aa34201
> Gonk: e7c90613521145db090dd24147afd5ceb5703190
> Version: 37.0 (2.2) 
> Firmware Version: v18D-1
> User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 17

[Noemí Freire (:noemi)]

(In reply to Jose Manuel Cantera from comment #16)
> (In reply to Jayme Mercado [:JMercado] from comment #15)
> > On the latest Nightly Flame 3.0 and 2.2 builds, the contacts details view
> > when adding through the messages app does not corrupt special characters. 
> > However the filename as expected according to step 2 of the description is
> > still incorrect.
> > 
> > Is this the expected results from your changes Jose?
> 
> Yes, we did not fix anything related to the filename, only to the content. 
> 

A follow up Bug 1138826 has been opened to track it. Thanks!

Comment 18

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Setting the flags for this issue as verified per comment 16 and my testing yesterday.