1121920 - [Dialer][CallScreen] JavaScript Error: "InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Germán Toro del Valle (:gtorodelvalle)]

STR

1. Place an outgoing call and accept the call on the other end.
2. Place an incoming call.
3. Answer the incoming call. The previous call is now held and the incoming (call waiting) call is now connected.
4. Merge the calls in a conference.
5. End the conference call.

OBSERVED:
Although everything seems to be working fine, the following error is shown in the console:
[JavaScript Error: "InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable" {file: "app://callscreen.gaiamobile.org/js/calls_handler.js" line: 241}]

EXPECTED:
No error should be shown in the console.

Comment 1

[Gabriele Svelto [:gsvelto]]

Bizarre, I've seen this happen when trying to use an IndexedDB transaction after it has completed. I think that it's thrown by native objects coming from Gecko that have exhausted their purpose but are still referenced by JS code. Considering where it's happening I wonder if we use a TelephonyCall object for a call that has already ended and removed from Telephony.calls or something similar.

Comment 2

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Pull request 27500

Once again the reason of this bug is the event notification flow notified by the RIL when a conference call is hung up. In this case, the callschanged event is notified when the remaining call state is 'disconnected'. We just have to control this case and avoid accessing this disconnected call as we were wrongly doing ;)

The point is that I do not recall seeing this log message on the console and it should have been there for a long time so I really do not know if there has been any change regarding the event notification flow on the backend side :(

Comment 3

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8551338 [details] [review]
Pull request 27500

LGTM, thanks for investigating this, last time I tracked one of these errors it took a while :-/

Comment 4

[Gabriele Svelto [:gsvelto]]

It seems like we forgot to land this after the r+, here it goes.

Comment 5

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#XBgFJTZjSACPXcgL9hosqg

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 6

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#auy48SRUSl-2Kb9Zg5MdxA

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] gabrielesvelto:bug-1121920 > mozilla-b2g:master

Comment 8

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8613487 [details] [review]
[gaia] gabrielesvelto:bug-1121920 > mozilla-b2g:master

Somehow I cannot land the other PR, maybe due to its age, let's try again with this one.

Comment 9

[Gabriele Svelto [:gsvelto]]

OK, let's see if this works.

Comment 10

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#HH_mkiMuSuuLJ0JnHZIshg

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 11

[Gabriele Svelto [:gsvelto]]

Manually merged to gaia/master 6464b98b6abf07aee45ef140b8fe9725b4971aa6

https://github.com/mozilla-b2g/gaia/commit/6464b98b6abf07aee45ef140b8fe9725b4971aa6

This is the try run:

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=537a1c7bd88f7f697e69fc218244f26252c6b12d