1121970 - debug output from printf_stderr gets clipped on Windows

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Jim Mathies [:jimm]]

http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsCRTGlue.cpp#340

blech.

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

Comment 2

[Benjamin Smedberg]

Comment on attachment 8550255 [details] [diff] [review]
patch

Please at least use nsAutoArrayPtr<char> instead of the manual new/delete. I feel like there has to be a better way here, but I'm not thinking of it offhand.

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8550255 [details] [diff] [review]
patch

Review of attachment 8550255 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the changes below.

::: xpcom/glue/nsCRTGlue.cpp
@@ +340,5 @@
>    if (IsDebuggerPresent()) {
> +    int lengthNeeded = _vscprintf(aFmt, aArgs);
> +    if (lengthNeeded) {
> +      lengthNeeded++;
> +      char* buf = new char[lengthNeeded];

Please use mozilla::UniquePtr (mozilla/UniquePtr.h) here.  Bonus points if you use MakeUnique:

auto buf = MakeUnique<char[]>(lengthNeeded);

@@ +348,5 @@
> +        vsnprintf(buf, lengthNeeded, aFmt, argsCpy);
> +        buf[lengthNeeded - 1] = '\0';
> +        va_end(argsCpy);
> +        OutputDebugStringA(buf);
> +        delete [] buf;

...and then you don't need this.

@@ +350,5 @@
> +        va_end(argsCpy);
> +        OutputDebugStringA(buf);
> +        delete [] buf;
> +      }
> +    } 

Nit: trailing whitespace.

Comment 4

[Jim Mathies [:jimm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9eb15c8bfabb

Comment 5

[Jim Mathies [:jimm]]

Attachment: patch

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/768f1c9ea4a1

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/768f1c9ea4a1