1122025 - Bluetoothd correctness fixes

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github tree

Hi Shawn,

The patch set depends on bug 1119746. I was hoping you could already give me feedback on the patches, so that the 'official' final review proceeds quickly after bug 1119746 landed.

Some remarks:

The best text I know of on writing daemon start-up code is in 'The Linux Programming Interface', Chapter 37. An alternative is available at [1].

The overhead of the wakelocks is minimal. I switched on and off Bluetooth and it only took ~20 wakelocks, each for only a few milliseconds.

[1] http://www.netzmafia.de/skripten/unix/linux-daemon-howto.html

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

This patch set improves reliability of the Bluetooth daemon, so I'd like to land it in 2.2. I think the risk is minimal, and the changes can be rolled back easily.

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #2)
> This patch set improves reliability of the Bluetooth daemon, so I'd like to
> land it in 2.2. I think the risk is minimal, and the changes can be rolled
> back easily.

True. I think overall the patch set is low risk and it shall improve reliability especially avoid unexpected behaviors when system goes into sleep mode. We shall have this patch set no matter what.

Comment 4

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Hi Howie,
We shall nominate this bug to 2.2 feature+.

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request

This pull request contains the original patch set with the fixed order of the header files in patch 4.

The other patches belong to bug 1119746. I'll remove them, once bug 1119746 landed.

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8551242 [details]
Github pull request

Updated Gihub pull request

  - rebased pull request on bug 1119746, no code changes

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8551242 [details]
Github pull request

It looks good to me.

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/platform_system_bluetoothd/commit/8a05fd72770a3b1fc23f3216a45318ad393fc4ca

Comment 10

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8551242 [details]
Github pull request

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): No
User impact if declined: We need to improve stability for bluetoothd in v2.2
Testing completed: Test if wake lock can be properly released
Risk to taking this patch (and alternatives if risky): No
String or UUID changes made by this patch:None

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/platform_system_bluetoothd/commit/5cc45b3b17ce99ec91651abf2066925ad1db3e47