1122092 - Update analyze_graphapi to run with current Perfomatic API

Status: RESOLVED FIXED

(Webtools Graveyard :: Graph Server, defect)

Description

[Alice Scarpa [:adusca]]

graphs/server/analysis/analyze_graphapi.py's code was last touched on 2010, and the current Perf-o-matic API is no longer compatible with it. In particular, nowadays the list of tests at graphs.mozilla.org/api/test no longer returns a list of machines for each test, which was an assumption baked into the previous code.

Comment 1

[Alice Scarpa [:adusca]]

Attachment: Updated version of analyze_graphapi

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8549729 [details] [diff] [review]
Updated version of analyze_graphapi

Review of attachment 8549729 [details] [diff] [review]:
-----------------------------------------------------------------

overall this looks great, lets sort out the question below and address the indentation issue mentioned and we should be good to go!

::: server/analysis/analyze_graphapi.py
@@ -87,5 @@
> -                machines_by_branch[series].append(machine_id)
> -            if machine_id not in machine_names:
> -                machine_names[machine_id] = machine_info['name']
> -        self.machines_by_branch = machines_by_branch
> -        self.machine_names = machine_names

why are we removing this?  It appears we set this and then access it from analyze_talos.py for state == 'machine' via:
self.source.getMachineName(...)

@@ +116,5 @@
>                      #log.error("%s %s %s", seen[t], seen[t].machine_id, seen[t].run_number)
>                      #log.error("%s %s %s", d, d.machine_id, d.run_number)
>                      #log.error(url)
>                  #else:
>                      #seen[t] = d

this block should be unindented a few spaces

Comment 3

[Alice Scarpa [:adusca]]

Attachment: Updated version of analyze_graphapi

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8550343 [details] [diff] [review]
Updated version of analyze_graphapi

Review of attachment 8550343 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!  as discussed on irc, this is the api interface, not the db interface, so we are already not at parity- no need to require getting there.  This patch actually makes things a lot more useful!

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

landed:
http://hg.mozilla.org/graphs/rev/b07ae8c8b77a