Update analyze_graphapi to run with current Perfomatic API

RESOLVED FIXED

Status

Webtools Graveyard
Graph Server
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: adusca, Assigned: adusca)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
graphs/server/analysis/analyze_graphapi.py's code was last touched on 2010, and the current Perf-o-matic API is no longer compatible with it. In particular, nowadays the list of tests at graphs.mozilla.org/api/test no longer returns a list of machines for each test, which was an assumption baked into the previous code.
(Assignee)

Comment 1

3 years ago
Created attachment 8549729 [details] [diff] [review]
Updated version of analyze_graphapi
Attachment #8549729 - Flags: review?(jmaher)
Comment on attachment 8549729 [details] [diff] [review]
Updated version of analyze_graphapi

Review of attachment 8549729 [details] [diff] [review]:
-----------------------------------------------------------------

overall this looks great, lets sort out the question below and address the indentation issue mentioned and we should be good to go!

::: server/analysis/analyze_graphapi.py
@@ -87,5 @@
> -                machines_by_branch[series].append(machine_id)
> -            if machine_id not in machine_names:
> -                machine_names[machine_id] = machine_info['name']
> -        self.machines_by_branch = machines_by_branch
> -        self.machine_names = machine_names

why are we removing this?  It appears we set this and then access it from analyze_talos.py for state == 'machine' via:
self.source.getMachineName(...)

@@ +116,5 @@
>                      #log.error("%s %s %s", seen[t], seen[t].machine_id, seen[t].run_number)
>                      #log.error("%s %s %s", d, d.machine_id, d.run_number)
>                      #log.error(url)
>                  #else:
>                      #seen[t] = d

this block should be unindented a few spaces
Attachment #8549729 - Flags: review?(jmaher) → review-
(Assignee)

Comment 3

3 years ago
Created attachment 8550343 [details] [diff] [review]
Updated version of analyze_graphapi
Attachment #8549729 - Attachment is obsolete: true
Attachment #8550343 - Flags: review?(jmaher)
Comment on attachment 8550343 [details] [diff] [review]
Updated version of analyze_graphapi

Review of attachment 8550343 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!  as discussed on irc, this is the api interface, not the db interface, so we are already not at parity- no need to require getting there.  This patch actually makes things a lot more useful!
Attachment #8550343 - Flags: review?(jmaher) → review+
Assignee: nobody → alicescarpa
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
landed:
http://hg.mozilla.org/graphs/rev/b07ae8c8b77a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.