1122123 - Switching to async promises in protocol.js causes test failures in WebIDE

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Eddy Bruel [:ejpbruel]]

My latest attempt to remove the deprecated-sync-thenables from protocol.js (bug 1096490) had to be backed out because of test failures in WebIDE: https://treeherder.mozilla.org/logviewer.html#?job_id=1699115&repo=fx-team

These are the last two failing tests. If we can get these to pass the patch should be able to land.

Jryans said he'd take a look at these. Thanks, Jryans!

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Fix WebIDE tests with async promises

This should do it.  Waiting on try to open.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try including bug 1096490:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=153a03262528

Try with just this:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=91b4b2ed6fdf

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://hg.mozilla.org/integration/fx-team/rev/7b98d254877e

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7b98d254877e