112213 - Use timeline for perf measurements of folder and message loading

Status: RESOLVED EXPIRED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[varada]

Use timeline for perf measurements of folder and message loading

Comment 1

[varada]

Attachment: Adding timeline to functions.

Comment 2

[varada]

CCing mscott for reviews.

Comment 3

[Scott MacGregor]

can you post some numbers your getting varada? That way we can see if the
timeline stuff is working right and if the numbers make sense. I'm particularly
interested in seeing something like clicking on several messages of roughly the
same size and making sure the reset timer stuff is working (same for the folder
pane)

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Ran these for Varada. Performance numbers of his build vs. yesterday's trunk.

Comment 5

[varada]

469Kb message - three tries for accuracy - 1.583,1.572 and 1.582 seconds.

Comment 6

[Scott MacGregor]

sr=mscott then. thanks guys.

Comment 7

[ji]

What's the environment variable used to get the numbers?

Comment 8

[varada]

Attachment: Adding pref check for timeline

Checking for pref before using timeline to prevent being called in regular
builds.

Comment 9

[Scott MacGregor]

Comment on attachment 62542 [details] [diff] [review]
Adding pref check for timeline

sr=mscott but you should add this pref to mailnews.js and default it to false.
Then remove the try / catch around your pref reading code since it should never
return an error if you define a default value.

do you want to be disabling the timing code in nsMsgStatusFeedback if this pref
is set as well?

Comment 10

[varada]

Attachment: adding pref for timeline measurement in mail

Adding the mailnews.timeline_is_enabled pref to mailnews.js: default is false.

Comment 11

[varada]

The code in nsMsgStatusFeedback neednt be checked with the pref because they
wont be built without the timeline environment whereas we should safeguard JS
which is present always.

Comment 12

[Scott MacGregor]

Comment on attachment 62559 [details] [diff] [review]
adding pref for timeline measurement in mail

sr=mscott

Comment 13

[(not reading, please use [e-mail] instead)]

taking all of varada's bugs.

Comment 14

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 15

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420