Last Comment Bug 1122154 - Global isFirefoxUpToDate function should ignore ESR builds
: Global isFirefoxUpToDate function should ignore ESR builds
Status: RESOLVED FIXED
[kb=1632114]
:
Product: www.mozilla.org
Classification: Other
Component: Pages & Content (show other bugs)
: Production
: All All
-- major
: ---
Assigned To: Jon Petto [:jpetto]
:
:
Mentors:
Depends on:
Blocks: 1119115
  Show dependency treegraph
 
Reported: 2015-01-15 10:50 PST by Jon Petto [:jpetto]
Modified: 2015-01-22 22:07 PST (History)
8 users (show)
See Also:
Locale:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments

Description User image Jon Petto [:jpetto] 2015-01-15 10:50:39 PST
Currently, if a user with Firefox 31 (release) visits https://www.mozilla.org/en-US/firefox/desktop/, they do not see a download button (see bug 1119115).

This is due to Firefox 31 being an ESR build and our global isFirefoxUpToDate function ignoring users with version numbers that match ESR builds. See https://github.com/mozilla/bedrock/blob/master/media/js/base/global.js#L126

Unless there are conditions I'm unaware of, it seems a bit backwards to be making life more difficult for release users (majority) in favor of making sure ESR users (minority) do not see a download button.

Recommendation from today's triage is to change the global isFirefoxUpToDate function to ignore ESR builds.
Comment 1 User image [github robot] 2015-01-22 10:02:29 PST
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/f8f4a7ead3ecbf22d3901efe61c7d40c4bd9e955
Ignore ESR when checking isFirefoxUpToDate. Bug 1122154.

https://github.com/mozilla/bedrock/commit/bd766ce0714ff5d1e5ad80ec79ec9d0caae4e9f9
Merge pull request #2673 from jpetto/bug-1122154-fxisuptodate-ignore-esr

Ignore ESR when checking isFirefoxUpToDate. Bug 1122154.

Note You need to log in before you can comment on or make changes to this bug.