Closed Bug 1122162 Opened 6 years ago Closed 6 years ago
librecovery needs liblog in Lollipop
librecovery_test fails to build otherwise with the error below: librecovery_test (out/target/product/msm8909/obj/EXECUTABLES/librecovery_test_intermediates/LINKED/librecovery_test) librecovery/librecovery.c:68: error: undefined reference to '__android_log_print' librecovery/librecovery.c:111: error: undefined reference to '__android_log_print' librecovery/librecovery.c:123: error: undefined reference to '__android_log_print' librecovery/librecovery.c:137: error: undefined reference to '__android_log_print' collect2: error: ld returned 1 exit status
Hi Michael, Looks like this build error exist since JB Could you please help to review this patch? Thank you! Hi Diego, Could you please also check this patch in your side? It works in Nexus-5 with Lollipop. Thank you!
Attachment #8550221 - Flags: feedback?(dwilson) → feedback+
Is it possible to use the shared library version of this?
Oh nevermind, it's for a test, so that doesn't matter at all.
add reviewer in comment
Assignee: nobody → vwang
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S4 (23jan)
Viral, can we uplift this to 2.2 if ready ? :mvines shared that its already in CAF trees : https://www.codeaurora.org/cgit/quic/lf/b2g/build/tree/patch/LF.BR.1.2.3/librecovery/Bug-1122162-librecovery_test-needs-liblog.patch and is really low risk.
(In reply to bhavana bajaj [:bajaj] from comment #6) > Viral, can we uplift this to 2.2 if ready ? :mvines shared that its already > in CAF trees : > https://www.codeaurora.org/cgit/quic/lf/b2g/build/tree/patch/LF.BR.1.2.3/ > librecovery/Bug-1122162-librecovery_test-needs-liblog.patch and is really > low risk. Yes, I think it's ready to uplift to 2.2!
Comment on attachment 8550221 [details] [review] add liblog in Android.mk to fix the build error [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: [Testing completed]: [Risk to taking this patch] (and alternatives if risky): [String changes made]:
Attachment #8550221 - Flags: approval-gaia-v2.2?(bbajaj)
Attachment #8550221 - Flags: approval-gaia-v2.2?(bbajaj) → approval-gaia-v2.2+
You need to log in before you can comment on or make changes to this bug.