1122235 - set HAVE_UINT64_T for cairo compilation to improve codegen

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: set HAVE_UINT64_T for cairo compilation to improve codegen

We have stdint.h everywhere now, thanks to our new MSVC 2013 support.  Let's
take advantage of it by informing cairo that {u,}int64_t is always available.

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8549880 [details] [diff] [review]
set HAVE_UINT64_T for cairo compilation to improve codegen

> for var in ('CAIRO_HAS_PTHREAD', '_GNU_SOURCE'):
>     DEFINES[var] = True
> 
> for var in ('MOZ_TREE_CAIRO', 'MOZ_TREE_PIXMAN'):
>     if CONFIG[var]:
>         DEFINES[var] = True
> 
>+# Normally determined by cairo's configure script.
>+for var in ('HAVE_UINT64_T',):
>+    DEFINES[var] = True
>+

What's the point of the for loop? Seems you could either add this in the 'CAIRO_HAS_PTHREAD' / '_GNU_SOURCE' loop above or just do DEFINES['HAVE_UINT64_T'] = True if you wanted to keep it separate for the comment.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c6ece3462afd