1122243 - Webpay pop-up window is getting blocked by Firefox

Status: VERIFIED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect)

Description

[krupa raj[:krupa]]

37.0a1 (2015-01-09)

steps to reproduce:
1. User is not logged-in.
2. Search for 'Test zippy with me' on your desktop dev marketplace
3. Click on the purchase button
4. Sign in using your fxa account

expected behavior:
After sign in, the webpay page loads prompting the user to Enter PIN

actual behavior:
After sign in, Firefox blocks the pop-up window.

screencast: http://screencast.com/t/cqjIzz9mYj1

Comment 1

[Stuart Colville [:muffinresearch]]

When the user is not logged-in the click is used for the login process. Then once logged-in, the payment code is run programmatically resulting in the popup blocker blocking because the window wasn't created as part of the click.

Comment 2

[Stuart Colville [:muffinresearch]]

PR: https://github.com/mozilla/fireplace/pull/914

This is imperfect e.g. the UX isn't really up to snuff. But makes this usable at least.

Comment 3

[Stuart Colville [:muffinresearch]]

Kumar and I have discussed this and the plan for a better approach is documented here:

https://etherpad.mozilla.org/fireplace-pay-popup-madness

We may land https://github.com/mozilla/fireplace/pull/914 as an interim fix to help allow people to get further into the flow for QA purposes.

Comment 4

[Stuart Colville [:muffinresearch]]

Landed the interim fix here: https://github.com/mozilla/fireplace/commit/147625a9a3c32faf410d438e78456045035bd1c8 - keeping the bug open for now to continue with the improved version.

Comment 5

[Stuart Colville [:muffinresearch]]

Going to close this as the other pieces are now listed in other bugs.

Comment 6

[Victor Carciu]

Verified as fixed